More linting tweaks

[nnethercote]

Squeeze a little more blood from this stone.

r? @cjgillot

[nnethercote]

@bors try @rust-timer queue

[bors]

⌛ Trying commit d049be3 with merge 858ff1cdb6da6c41638d404e35a962f37e2fc512...

[bors]

☀️ Try build successful - checks-actions
Build commit: 858ff1cdb6da6c41638d404e35a962f37e2fc512 (858ff1cdb6da6c41638d404e35a962f37e2fc512)

[rust-timer]

Finished benchmarking commit (858ff1cdb6da6c41638d404e35a962f37e2fc512): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.3%	[-3.3%, -3.3%]	1
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	2
All ❌✅ (primary)	-3.3%	[-3.3%, -3.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

[cjgillot]

@bors r+

[bors]

📌 Commit d049be3 has been approved by cjgillot

It is now in the queue for this repository.

[nnethercote]

Disappoining perf results, I saw improvements locally. I guess with PGO/BOLT the version compiled on CI was already inlining those functions. Though they may still help platforms that aren't built with PGO/BOLT.

[bors]

⌛ Testing commit d049be3 with merge 85868c6419b82d9c77d6f17ddd82339a2827a375...

[bors]

💔 Test failed - checks-actions

[nnethercote]

Seems to be a network error, the failing log ends with several repetitions of this:

fatal: could not read Username for 'https://github.com/': No such device or address
Sleeping for 3 seconds before retrying push
From https://github.com/rust-lang-nursery/rust-toolstate
 * branch            master     -> FETCH_HEAD
HEAD is now at 496fb40 (windows CI update)
[master e3015cb] (linux CI update)
 1 file changed, 1 insertion(+)

@bors retry

[bors]

⌛ Testing commit d049be3 with merge 910b4af6a0a20dcd18974e9196a195f8daf5ecd6...

[bors]

💔 Test failed - checks-actions

[nnethercote]

@Mark-Simulacrum https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Authentication.20failed.20on.20merge.20attempt to retry now.

@bors retry

[bors]

⌛ Testing commit d049be3 with merge c6fcdb6...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing c6fcdb6 to master...

[rust-timer]

Finished benchmarking commit (c6fcdb6): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.4%	[1.4%, 1.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[0.9%, 3.4%]	3
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-3.0%	[-4.7%, -1.7%]	6
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Cycles

This benchmark run did not return any relevant results for this metric.