Rollup of 7 pull requests

[matthiaskrgr]

Successful merges:

• Realistic Path::as_mut_os_str doctest #105801 (Realistic Path::as_mut_os_str doctest)
• Add long error docs for E0460 and E0457 #105860 (Add long error docs for E0460 and E0457)
• Test that we don't add a new kind of breaking change with TAITs #105895 (Test that we don't add a new kind of breaking change with TAITs)
• docs: improve pin docs #105902 (docs: improve pin docs)
• Update books #105910 (Update books)
• rustdoc: remove width-limiter from source pages, stop overriding CSS #105913 (rustdoc: remove width-limiter from source pages, stop overriding CSS)
• Revert "Replace usage of ResumeTy in async lowering with Context" #105915 (Revert "Replace usage of ResumeTy in async lowering with Context")

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=7

[bors]

📌 Commit 575b2a2 has been approved by matthiaskrgr

It is now in the queue for this repository.

[lqd]

Should we lower the priority on this rollup, there's a PR fixing a P-critical in the queue, #105905, or does this one also fix another such high priority issue ?

[Nilstrieb]

If we want to get the revert merged today we should raise its priority instead of lowering the priority of other PRs. The only PR in the rollup that could matter whether we land it now or later is #105501 which is also a regression but that seems to be hit significantly less than the P-critical revert. I think we should raise the priority of that PR to 10.

[lqd]

I also agree that the revert PR should be higher prio, it's not about lowering other PRs but this rollup in particular, which has p=7 and IIUC the forge documents such >5 prio to be for P-critical issues, hence my question.

[tmandry]

Note that #105915 is a revert that fixes #105501, which also meets the criteria for P-critical. It was not marked as such and I think #105905 is probably more important based on the number of issues filed for it.

[bors]

⌛ Testing commit 575b2a2 with merge c43bc13...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing c43bc13 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#105915	97eddb81a1acdf4e034ae7265d425e19dae419b8
#105913	6157d095be8503ec44f24557aa791839c31daeee
#105910	f4251155e541b8d384c3560cc9be75b4d23ccf3e
#105902	52aea5d207ebc0ff94ebbdf3163198e313400f70
#105895	2b0f325351164a7784c19172d1cfaefbf584499c
#105860	1f427700b501d04286f1a55dd5cefffcab658d74
#105801	7e62b3f85811cc721ccd0588fe7f8fefbcc1d32a

previous master: 696563efc5

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (c43bc13): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-4.4%, -0.8%]	12
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-5.4%, -1.5%]	12
All ❌✅ (primary)	-	-	0

[nnethercote]

Just one miniscule regression in a doc result: not a problem.

@rustbot label: +perf-regression-triaged