Rollup of 6 pull requests #106111
Merged
Rollup of 6 pull requests #106111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see rust-lang#94173 and commit 27011b4.
…e with expected
FileCheck provides 5 lines of context by default. This is often insufficient to analyze failures that happen in CI. Increase the amount of context to 100 lines.
The other places are more accurate and up-to-date. - Link to `std-dev-guide` in CONTRIBUTING.md Thom and Mara said the guide is in reasonably good shape, and it's tailored more closely to people working on the standard library. - Link to CONTRIBUTING.md instead of rustc-dev-guide in the main readme CONTRIBUTING.md has more information and also links the std-dev-guide. - Link to forge for the list of tested platforms; the one in the readme was hopelessly out of date.
The goal is to remove this altogether from the dev-guide once this PR is merged.
This sets several useful defaults, like `extended = true`, and gives us a path forward for changing global defaults without breaking distros.
Improve top-level docs See a detailed explanation in the commit messages. This is a companion PR to rust-lang/rustc-dev-guide#1528. * Link to other resources instead of inlining their information * Remove ancient and outdated reference to `config.mk` * Suggest `profile = "user"` in the README * Add detail about dependencies from the dev-guide * Link to CONTRIBUTING.md instead of rustc-dev-guide in the main readme * Link to `std-dev-guide` in CONTRIBUTING.md
…e-method-call, r=eholk Suggest remove last method call when type coerce with expected type Fixes rust-lang#105494
std: only use LFS function on glibc see rust-lang#94173 and commit 27011b4.
…mulacrum Provide more context on FileCheck failures FileCheck provides 5 lines of context by default. This is often insufficient to analyze failures that happen in CI. Increase the amount of context to 100 lines.
…=compiler-errors Codegen test for derived `<` on trivial newtype [TEST ONLY] I originally wrote this for rust-lang#106065, but the libcore changes there aren't necessarily a win. So I pulled out this test to be its own PR since it's important (see rust-lang#105840 (comment)) and well-intentioned changes to core or the derive could accidentally break it without that being obvious (other than by massive unexplained perf changes).
…r=GuillaumeGomez rustdoc: make line number CSS for doc comment and scraped the same  Discussed in https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Line.20number.20styling Preview: http://notriddle.com/notriddle-rustdoc-demos/source-lines/test_dingus/fn.test.html
rustbot
added
T-bootstrap
|
@bors r+ rollup=never p=6 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 5e8bab91d3 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Dec 24, 2022
Closed
|
Finished benchmarking commit (8766bbd): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
<on trivial newtype [TEST ONLY] #106100 (Codegen test for derived<on trivial newtype [TEST ONLY])Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup