Add new bootstrap members to triagebot.toml

[albertlarsan68]

@ozkanonur if you want to be assigned to review PRs too, just post a message to this thread.

Should a T-bootstrap label be created, since src/tools/tidy is assigned to the bootstrap members, but labeled A-testsuite (and not A-bootstrap) ?

cc @jyn514

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[onur-ozkan]

if you want to be assigned to review PRs too, just post a message to this thread.

Yes, I would like to.

[jyn514]

Should a T-bootstrap label be created, since src/tools/tidy is assigned to the bootstrap members, but labeled A-testsuite (and not A-bootstrap) ?

I think renaming A-bootstrap to T-bootstrap is fine, but I don't think we need a special label just to distinguish tidy - if you're not comfortable reviewing changes to it, you can assign Mark directly without assigning the whole bootstrap team.

[albertlarsan68]

I meant that now, the tidy tool is assigned to the bootstrap ad-hoc team, but currently gets the A-testsuite label. It is the case with others parts, I gave tidy as an example.

[jyn514]

My question to you is: are those tools you're interested in working on? :)

Bootstrap does not have a formal mandate and "build system" is quite broad. If you want to be involved in those tools, I think labeling them as bootstrap is totally fine. If you don't want to be involved in those tools, I think removing the bootstrap team from the list of reviewers is also totally fine.

I would be curious to hear if @Mark-Simulacrum has opinions on whether tidy/compiletest/rust-installer should be under T-bootstrap's mandate or not.

[albertlarsan68]

I would move tidy to the T-bootstrap team, and leave the rest in the A-testsuite label, maybe additionally adding the T-bootstrap label.

If I read triagebot.toml correctly, those paths are assigned to bootstrap:

• src/bootstrap
• src/stage0.json: This is labeled to T-release and A-bootstrap
• src/tools/compiletest: Labeled as A-testsuite
• src/tools/rust-installer
• src/tools/tidy: Labeled as A-testsuite
• src/tools/x

Some of the tools labeled as A-testsuite do not have assign directives.

[jyn514]

That sounds reasonable to me :)

[albertlarsan68]

What is the process for the rename of the A-bootstrap label to T-bootstrap?

[jyn514]

Done just now :) (if you need to do this yourself, I went to https://github.com/rust-lang/rust/labels?q=bootstrap in the web interface and clicked the edit button)

[albertlarsan68]

I would have done that once the autolabel is changed, but I do not have write rights to the rust repo.

@ozkanonur and @Mark-Simulacrum do you have thoughts ?

[onur-ozkan]

src/tools/tidy is assigned to the bootstrap members, but labeled A-testsuite (and not A-bootstrap) ?

I think tidy should either not assign bootstrap members or be labeled as A-bootstrap. Because right now it seems confusing to me :)

p.s: rustbot gets confused by A-bootstrap currently.
ref #106621 (comment)

[albertlarsan68]

I reverted the tidy label move.
@ozkanonur, if you don't feel like reviewing tidy changes, feel free to reassign it to another member of the team.

[Mark-Simulacrum]

@bors r+ rollup

[bors]

📌 Commit fa7d17d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[jyn514]

I've updated the A-bootstrap label back to T-bootstrap :)