Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate the hir-stats.rs tests on stage 1. #107577

Merged
merged 1 commit into from Feb 2, 2023
Merged

Reinstate the hir-stats.rs tests on stage 1. #107577

merged 1 commit into from Feb 2, 2023

Conversation

nnethercote
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 1, 2023
@nnethercote
Copy link
Contributor Author

@bors rollup=always

@jyn514
Copy link
Member

jyn514 commented Feb 2, 2023

It seems unfortunate to have tests that aren't run in CI ... is there a reason we shouldn't keep // ignore-stage1 here permanently?

@nnethercote
Copy link
Contributor Author

I think ignore-stage1 should be avoided as much as possible. It's annoying to run x test tests/ui and everything passes and you think you're good and then you realize much later that an ignore-stage1 test was skipped and fails with stage 2.

@jyn514
Copy link
Member

jyn514 commented Feb 2, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Feb 2, 2023

📌 Commit e30cd18 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 2, 2023
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 2, 2023
@Dylan-DPC
Rollup merge of rust-lang#107577 - nnethercote:reinstate-hir-stats, r…
c42995b 
…=jyn514

Reinstate the `hir-stats.rs` tests on stage 1.

r? `@the8472`
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 2, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 2, 2023
@matthiaskrgr
Rollup merge of rust-lang#107577 - nnethercote:reinstate-hir-stats, r…
09a9dd0 
…=jyn514

Reinstate the `hir-stats.rs` tests on stage 1.

r? ``@the8472``
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 2, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2023
@bors
Auto merge of rust-lang#107601 - matthiaskrgr:rollup-07zaafe, r=matth…
f312650 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106919 (Recover `_` as `..` in field pattern)
 - rust-lang#107493 (Improve diagnostic for missing space in range pattern)
 - rust-lang#107515 (Improve pretty-printing of `HirIdValidator` errors)
 - rust-lang#107524 (Remove both StorageLive and StorageDead in CopyProp.)
 - rust-lang#107532 (Erase regions before doing uninhabited check in borrowck)
 - rust-lang#107559 (Rename `rust_2015` → `is_rust_2015`)
 - rust-lang#107577 (Reinstate the `hir-stats.rs` tests on stage 1.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 08181ea into rust-lang:master Feb 2, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 2, 2023
@nnethercote nnethercote deleted the reinstate-hir-stats branch February 2, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@the8472 the8472

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nnethercote @jyn514 @bors @the8472 @rustbot