Rollup of 8 pull requests

[compiler-errors]

Successful merges:

• Make const/fn return params more suggestable #106887 (Make const/fn return params more suggestable)
• Add type alias for raw OS errors #107519 (Add type alias for raw OS errors)
• Replace ConstFnMutClosure with const closures  #107551 ( Replace ConstFnMutClosure with const closures )
• Retry opening proc-macro DLLs a few times on Windows. #107595 (Retry opening proc-macro DLLs a few times on Windows.)
• Replace nbsp in all rustdoc code blocks #107615 (Replace nbsp in all rustdoc code blocks)
• Intern external constraints in new solver #107621 (Intern external constraints in new solver)
• loudly tell people when they change Cargo.lock #107631 (loudly tell people when they change Cargo.lock)
• Clarifying that .map() returns None if None. #107632 (Clarifying that .map() returns None if None.)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[compiler-errors]

@bors r+ rollup=never p=1

[bors]

📌 Commit 13bd75f has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 13bd75f with merge 6cc8a565e0128d5deef986200873db86febc16ea...

[bors]

💔 Test failed - checks-actions

[compiler-errors]

@bors retry

[bors]

⌛ Testing commit 13bd75f with merge 886b2c3...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 886b2c3 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#107632	c5b3bb000d31f620ce79545e6bd92c3a9eb23dfe
#107631	3521401835c796dd4fee3016125beef24b630580
#107621	5075e2af4f96bbf1e807aa5e36e951d1df92a661
#107615	750e8839355ab95d7265cd5363f7d95bf7b5b7e7
#107595	e7302f7680c4fedd4d1867222b47314fefc693ce
#107551	f8535db4a238c28dc483adc03ad8b3a6337b4513
#107519	d0bfa4844bca41e6bec45cd0f0c181ed6a648d6a
#106887	a5298d50f67ad01e67f4aad75abf94077a7550b6

previous master: 658fad6c55

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (886b2c3): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.4%	[0.3%, 6.2%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.4%	[-7.4%, -7.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	2.4%	[1.6%, 3.5%]	17
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	1
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	1.1%	[-0.0%, 2.2%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.7%, 3.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-4.4%, -3.2%]	2
All ❌✅ (primary)	-	-	0

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:ac593985615ec2ede58e132d2e21d2b1cbd6127c)
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/ac593985615ec2ede58e132d2e21d2b1cbd6127c'. Error: Resource temporarily unavailable (codeload.github.com:443)
##[warning]Back off 26.81 seconds before retry.
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/ac593985615ec2ede58e132d2e21d2b1cbd6127c'. Error: Resource temporarily unavailable (codeload.github.com:443)
##[warning]Back off 24.923 seconds before retry.
##[error]Resource temporarily unavailable (codeload.github.com:443)

[pnkfelix]

• the vast bulk regressions are on six variations of secondary benchmarks match-stress
• and all of those appear to to have all been resolved by follow-on PR Remove OnHit callback from query caches. #107667
• marking as triaged.

@rustbot label: +perf-regression-triaged