Run expand-yaml-anchors in x test tidy
#107704
Conversation
Previously, the pre-commit hook which runs `x test tidy` could pass only to have CI fail within the first 30 seconds. This adds about 30 seconds to `test tidy` (for an initial run, much less after the tool is built the first time) in exchange for catching errors in `.github/workflows/ci.yml` before they're pushed.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
| @@ -1134,6 +1131,11 @@ help: to skip test's attempt to check tidiness, pass `--exclude src/tools/tidy` | |||
| } | |||
| crate::format::format(&builder, !builder.config.cmd.bless(), &[]); | |||
| } | |||
|
|
|||
| builder.info("tidy check"); | |||
| try_run(builder, &mut cmd); | |||
There was a problem hiding this comment.
This change isn't strictly necessary, but I personally find that I have broken formatting way more commonly than any other issue, so it seems nice to run that check first.
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (e4dd9ed): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
|
This has to be noise, I didn't touch anything except CI code. |
|
the performance graph for cranelift check does indicate some up-and-down swings that seem to have only started recently, possibly correlated with #107627 though I don't know how that would introduce noise. the graph for keccak check also has recent injection of up-and-down swings that also correlated with #107627. I see that @nnethercote actually asked about recent noise on zulip, so I'll ping them and see what they think root cause might be. @rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
Previously, the pre-commit hook which runs
x test tidycould pass only to have CI fail within the first 30 seconds. This adds about 30 seconds totest tidy(for an initial run, much less after the tool is built the first time) in exchange for catching errors in.github/workflows/ci.ymlbefore they're pushed.