correctly update goals in the cache #107799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Team or group rust-lang team names can be found at https://github.com/rust-lang/team/tree/master/teams. |
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
lcnr
commented
Feb 8, 2023
|
r=me with tidy happy and commits squashed |
lcnr
commented
Feb 8, 2023
| @@ -0,0 +1,38 @@ | |||
| // known-bug: unknown | |||
There was a problem hiding this comment.
currently still ICEs because other part of the solver aren't implemented yet 😅
lcnr
force-pushed
the
update-provisional-result
branch
from
4ce7b26
to
4c7c5e5
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
@bors r=oli-obk |
|
💡 This pull request was already approved, no need to approve it again.
|
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 9, 2023
…oli-obk correctly update goals in the cache we may want to actually write the response for our goal into the provisional or global cache instead of simply using the result from the last iteration '^^ r? `@rust-lang/initiative-trait-system-refactor`
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 9, 2023
…oli-obk correctly update goals in the cache we may want to actually write the response for our goal into the provisional or global cache instead of simply using the result from the last iteration '^^ r? ``@rust-lang/initiative-trait-system-refactor``
This was referenced Feb 9, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 9, 2023
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#107317 (Implement `AsFd` and `AsRawFd` for `Rc`) - rust-lang#107429 (Stabilize feature `cstr_from_bytes_until_nul`) - rust-lang#107713 (Extend `BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE`.) - rust-lang#107761 (Replace a command line flag with an env var to allow tools to initialize the tracing loggers at their own discretion) - rust-lang#107790 ( x.py fails all downloads that use a tempdir with snap curl rust-lang#107722) - rust-lang#107799 (correctly update goals in the cache) - rust-lang#107813 (Do not eagerly recover for bad `impl Trait` types in macros) - rust-lang#107817 (rustdoc: use svgo to shrink `wheel.svg`) - rust-lang#107819 (Set `rust-analyzer.check.invocationLocation` to `root`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we may want to actually write the response for our goal into the provisional or global cache instead of simply using the result from the last iteration '^^
r? @rust-lang/initiative-trait-system-refactor