Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce interning #107869

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Reduce interning #107869

merged 3 commits into from
Feb 13, 2023

Conversation

nnethercote
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 10, 2023
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 10, 2023
@bors
Copy link
Contributor

bors commented Feb 10, 2023

⌛ Trying commit 887a7fa13cb419f29bd31baf1a8edd5634c9c0af with merge 0ec14f32e473219e6d78a4fe07fd46aeead0e21e...

compiler-errors
compiler-errors approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit about mk_array_const's name, r=me if/when perf comes back green.

compiler/rustc_middle/src/ty/context.rs Show resolved Hide resolved
compiler/rustc_const_eval/src/transform/check_consts/qualifs.rs Show resolved Hide resolved
compiler/rustc_middle/src/ty/context.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Feb 10, 2023

☀️ Try build successful - checks-actions
Build commit: 0ec14f32e473219e6d78a4fe07fd46aeead0e21e (0ec14f32e473219e6d78a4fe07fd46aeead0e21e)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0ec14f32e473219e6d78a4fe07fd46aeead0e21e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.7%, -0.3%] 9
Improvements ✅
(secondary)		 -1.3% [-2.6%, -0.3%] 17
All ❌✅ (primary) -0.4% [-0.7%, -0.3%] 9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.1% [3.1%, 3.1%] 1
Regressions ❌
(secondary)		 2.8% [1.9%, 4.0%] 17
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.7% [-1.8%, -1.5%] 4
All ❌✅ (primary) 3.1% [3.1%, 3.1%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)		 -3.2% [-4.5%, -1.0%] 6
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 10, 2023
@nnethercote
Pre-intern some commonly used type variables.
6248bbb 
This requires some rearrangement of plumbing, such as adding
`mk_fresh_{,int_,float_}ty` and removing `mk_ty_infer`.
@nnethercote
Reduce direct mk_ty usage.
7a72560 
We use more specific `mk_*` functions in most places, might as well use
them as much as possible.
@nnethercote
Avoid interning empty tuples.
e261665
@nnethercote
Copy link
Contributor Author

I addressed the review comments.

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Feb 12, 2023

📌 Commit e261665 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2023
@bors
Copy link
Contributor

bors commented Feb 13, 2023

⌛ Testing commit e261665 with merge 7740f9a...

@bors bors mentioned this pull request Feb 13, 2023
Merged
@bors
Copy link
Contributor

bors commented Feb 13, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 7740f9a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 13, 2023
@bors bors merged commit 7740f9a into rust-lang:master Feb 13, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 13, 2023
@bors bors mentioned this pull request Feb 13, 2023
Merged
@bors bors mentioned this pull request Feb 13, 2023
Closed
3 tasks
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7740f9a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.4% [-2.6%, -0.4%] 12
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.1% [3.1%, 3.1%] 1
Regressions ❌
(secondary)		 3.6% [3.6%, 3.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.6% [-5.0%, -1.8%] 4
All ❌✅ (primary) 3.1% [3.1%, 3.1%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.1% [-1.3%, -0.9%] 2
Improvements ✅
(secondary)		 -3.1% [-3.9%, -2.1%] 8
All ❌✅ (primary) -1.1% [-1.3%, -0.9%] 2

@nnethercote nnethercote deleted the reduce-interning branch February 13, 2023 22:59
@nnethercote nnethercote mentioned this pull request Feb 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2023
@bors
Auto merge of rust-lang#108020 - nnethercote:opt-mk_region, r=compile…
c5d1b3e 
…r-errors

Optimize `mk_region`

PR rust-lang#107869 avoiding some interning under `mk_ty` by special-casing `Ty` variants with simple (integer) bodies. This PR does something similar for regions.

r? `@compiler-errors`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

@lcnr lcnr lcnr left review comments

@jackh726 jackh726 jackh726 left review comments

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nnethercote @rust-timer @bors @compiler-errors @lcnr @jackh726 @rustbot