Improve building compiler artifacts output #108171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Manishearth
approved these changes
Feb 17, 2023
this is quite difficult to do unfortunately :( cc #86022 (comment) |
|
it turns out I had time for this after all r? @jyn514 |
jyn514
reviewed
Feb 17, 2023
There was a problem hiding this comment.
this is awesome ❤️ ❤️ ❤️
some more things I tried that all worked great:
; x dist --dry-run clippy
Building bootstrap
Finished dev [unoptimized] target(s) in 0.04s
Building stage0 library artifacts (aarch64-apple-darwin)
Building compiler artifacts (stage0 -> stage1)
Assembling stage1 compiler
Building stage1 library artifacts (aarch64-apple-darwin)
Building compiler artifacts (stage1 -> stage2)
Building tool clippy-driver (stage1 -> stage2)
Building tool cargo-clippy (stage1 -> stage2)
Building tool rust-installer (stage0)
Dist clippy-1.69.0-dev-aarch64-apple-darwin
; x build --dry-run rustdoc miri --target x86_64-unknown-linux-gnu library
Building bootstrap
Finished dev [unoptimized] target(s) in 0.04s
Building stage0 library artifacts (aarch64-apple-darwin)
Building compiler artifacts (stage0 -> stage1)
Assembling stage1 compiler
Building stage1 library artifacts (aarch64-apple-darwin -> x86_64-unknown-linux-gnu)
Building rustdoc (stage0 -> stage1)
Building stage1 library artifacts (aarch64-apple-darwin)
Building compiler artifacts (stage1 -> stage2)
Building tool miri (stage1 -> stage2)
; x t --stage 1 rustc_data_structures --dry-run
Building bootstrap
Finished dev [unoptimized] target(s) in 0.15s
Building stage0 library artifacts (aarch64-apple-darwin)
Building compiler artifacts (stage0 -> stage1)
Assembling stage1 compiler
Building stage1 library artifacts (aarch64-apple-darwin)
Building rustdoc (stage0 -> stage1)
Testing {rustc_data_structures} stage1 (aarch64-apple-darwin -> aarch64-apple-darwin)
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
@jyn514 thanks for the feedback! I'm glad it's already proving a bit useful 😁 I wanted to get something up for review quickly in case there were mistakes. I'll refactor this and mark it as ready when it's up. |
mattjperez
force-pushed
the
compiler-artifacts-output
branch
from
4e382f3
to
1b4f995
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jyn514
approved these changes
Feb 19, 2023
src/bootstrap/tool.rs
Outdated
| fn tooling_output( | ||
| mode: Mode, | ||
| tool: &str, | ||
| stage: u32, |
There was a problem hiding this comment.
nit: because you're doing math on it, please name it build_stage. Then in the Rustdoc Step, you can pass in build_compiler.stage instead of doing math on target_compiler.stage.
|
@bors delegate=mattjperez rollup (please use |
|
✌️ @mattjperez can now approve this pull request |
mattjperez
force-pushed
the
compiler-artifacts-output
branch
from
1b4f995
to
551b894
Compare
mattjperez
force-pushed
the
compiler-artifacts-output
branch
from
551b894
to
40f012a
Compare
|
@bors r=jyn514 😁 |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 20, 2023
…ut, r=jyn514 Improve building compiler artifacts output Fixes rust-lang#108051 `@Manishearth,` `@jyn514` mentioned you might be interested in these changes to the outputs.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 20, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#108124 (Document that CStr::as_ptr returns a type alias) - rust-lang#108171 (Improve building compiler artifacts output) - rust-lang#108200 (Use restricted Damerau-Levenshtein distance for diagnostics) - rust-lang#108259 (remove FIXME that doesn't require fixing) - rust-lang#108265 ("`const` generic" -> "const parameter") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 26, 2023
…lbertlarsan68 bootstrap: Update the output of the `check` descriptions This should bring the output from `x check` in line with the changes in rust-lang#108171
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 26, 2023
…lbertlarsan68 bootstrap: Update the output of the `check` descriptions This should bring the output from `x check` in line with the changes in rust-lang#108171
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 27, 2023
…lbertlarsan68 bootstrap: Update the output of the `check` descriptions This should bring the output from `x check` in line with the changes in rust-lang#108171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108051
@Manishearth, @jyn514 mentioned you might be interested in these changes to the outputs.