Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some more non_lifetime_binders stuff with higher-ranked trait bounds #108189

Merged
merged 3 commits into from
Feb 19, 2023
Merged

Fix some more non_lifetime_binders stuff with higher-ranked trait bounds #108189

merged 3 commits into from
Feb 19, 2023

Conversation

compiler-errors
Copy link
Member

  1. When assembling candidates for for<T> T: Sized, we can't ICE because the self-type is a bound type.
  2. Fix an issue where, when canonicalizing in non-universe preserving mode, we don't actually set the universe for placeholders to the root even though we do the same for region vars.
  3. Make Placeholder("T") format like T in error messages.

Fixes #108180
Fixes #108182

r? types

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 17, 2023
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 18, 2023

📌 Commit a04832b1396ceb3bc30818f502f12edba7fd5446 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2023
@compiler-errors
Copy link
Member Author

Needs tests blessed, will do later

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2023
@compiler-errors
Copy link
Member Author

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Feb 18, 2023

📌 Commit 6f3706e has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 19, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2023
@bors
Auto merge of rust-lang#108228 - Dylan-DPC:rollup-i9t13qu, r=Dylan-DPC
eebdfb5 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#104659 (reflow the stack size story)
 - rust-lang#106933 (Update documentation of select_nth_unstable and select_nth_unstable_by to state O(n^2) complexity)
 - rust-lang#107783 (rustdoc: simplify DOM for `.item-table`)
 - rust-lang#107951 (resolve: Fix doc links referring to other crates when documenting proc macro crates directly)
 - rust-lang#108130 ("Basic usage" is redundant for there is just one example)
 - rust-lang#108146 (rustdoc: hide `reference` methods in search index)
 - rust-lang#108189 (Fix some more `non_lifetime_binders` stuff with higher-ranked trait bounds)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c5d5c57 into rust-lang:master Feb 19, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 19, 2023
@compiler-errors compiler-errors added the F-non_lifetime_binders `#![feature(non_lifetime_binders)]` label Mar 10, 2023
@compiler-errors compiler-errors deleted the non_lifetime_binders-bound-stuff branch August 11, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
F-non_lifetime_binders `#![feature(non_lifetime_binders)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
4 participants
@compiler-errors @jackh726 @bors @rustbot