Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #108465

Closed

Conversation

compiler-errors
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

icedrocket and others added 28 commits February 10, 2023 17:00
Lint against `Iterator::map` receiving a callable that returns `()`

Close rust-lang#106991
…or-auto, r=lcnr

Treat `str` as containing `[u8]` for auto trait purposes

Wanted to gauge `@rust-lang/lang` and `@rust-lang/types` teams' thoughts on treating `str` as "containing" a `[u8]` slice for auto-trait purposes.

`@dtolnay` brought this up in rust-lang#13231 (comment) as a blocker for future `str` type librarification, and I think it's both a valid concern and very easy to fix. I'm interested in actually doing that `str` type librarification (rust-lang#107939), but this probably should be considered in the mean time regardless of that PR.

r? types for the impl, though this definitely needs an FCP.
…-107918, r=notriddle

Add regression test for rust-lang#107918

Fixes rust-lang#107918.

r? `@notriddle`
…anicked, r=estebank

make "proc macro panicked" translatable
…r=GuillaumeGomez

docs/test: add UI test and docs for `E0476`

Final undocumented error code. Not entirely sure about wording in the docs.

Part of rust-lang#61137.

r? `@compiler-errors`

cc `@compiler-errors`
…er-errors

Add known-bug tests for a few I-unsound issues

Just a few commits to push rust-lang#105107 forward.

r? `@jackh726`
…solved, r=compiler-errors

Do not lint ineffective unstable trait impl for unresolved trait
… r=compiler-errors

Complete migrating `ast_passes` to derive diagnostics

cc rust-lang#100717

`@rustbot` label +A-translation
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2023
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative rollup A PR which is a rollup labels Feb 25, 2023
@compiler-errors
Copy link
Member Author

@bors r+ rollup=never p=9

@bors
Copy link
Contributor

bors commented Feb 25, 2023

📌 Commit 91a6f37 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2023
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking rustc_codegen_llvm v0.0.0 (/checkout/compiler/rustc_codegen_llvm)
error[E0425]: cannot find value `infcx` in this scope
  --> compiler/rustc_trait_selection/src/solve/trait_goals/structural_traits.rs:29:28
   |
29 |         ty::Str => Ok(vec![infcx.tcx.mk_slice(infcx.tcx.types.u8)]),

error[E0425]: cannot find value `infcx` in this scope
  --> compiler/rustc_trait_selection/src/solve/trait_goals/structural_traits.rs:29:47
   |
   |
29 |         ty::Str => Ok(vec![infcx.tcx.mk_slice(infcx.tcx.types.u8)]),

For more information about this error, try `rustc --explain E0425`.
error: could not compile `rustc_trait_selection` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

@compiler-errors compiler-errors deleted the rollup-4xkarz7 branch August 11, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet