Further unify validity intrinsics #108505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
Thanks for the PR, @Nilstrieb! I'll take a closer look shortly. |
Nilstrieb
added
S-blocked
|
☔ The latest upstream changes (presumably #108521) made this pull request unmergeable. Please resolve the merge conflicts. |
Also merges the inhabitedness check into the query to further unify the code paths.
rust-cloud-vms
bot
force-pushed
the
further-unify-validity-intrinsics
branch
from
bfcc46c
to
5f593da
Compare
|
Looks good to me -- much more unified indeed 🙂 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#108376 (compiler/rustc_session: fix sysroot detection logic) - rust-lang#108400 (add llvm cgu instructions stats to perf) - rust-lang#108496 (fix rust-lang#108495, postfix decrement and prefix decrement has no warning) - rust-lang#108505 (Further unify validity intrinsics) - rust-lang#108520 (Small cleanup to `one_bound_for_assoc_type`) - rust-lang#108560 (Some `infer/mod.rs` cleanups) - rust-lang#108563 (Make mailmap more correct) - rust-lang#108564 (Fix `x clean` with specific paths) - rust-lang#108571 (Add contains_key to SortedIndexMultiMap) - rust-lang#108578 (Update Fuchsia platform team members) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also merges the inhabitedness check into the query to further unify the
code paths.
Depends on #108364