Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new solver: make all goal evaluation able to be automatically rerun #108896

Merged
merged 9 commits into from
Mar 21, 2023
Merged

new solver: make all goal evaluation able to be automatically rerun #108896

merged 9 commits into from
Mar 21, 2023

Commits on Mar 16, 2023

  1. replace usage of evaluate_goal with a new add_goal

    @BoxyUwU
    BoxyUwU committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    ed63201 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. review nits

    @BoxyUwU
    BoxyUwU committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    ee31e5f View commit details
    Browse the repository at this point in the history

  2. add assert

    @BoxyUwU
    BoxyUwU committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    ea08d3a View commit details
    Browse the repository at this point in the history

  3. add comments 

    Co-authored-by: lcnr <rust@lcnr.de>
    @BoxyUwU @lcnr
    BoxyUwU and lcnr committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    ce14a1e View commit details
    Browse the repository at this point in the history

  4. UNACEPTABLE

    @BoxyUwU
    BoxyUwU committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e06c62c View commit details
    Browse the repository at this point in the history

  5. fix let else unformatting

    @BoxyUwU
    BoxyUwU committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    aa8de17 View commit details
    Browse the repository at this point in the history

  6. replace chain with two add_goal

    @BoxyUwU
    BoxyUwU committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e624ef4 View commit details
    Browse the repository at this point in the history

  7. fix bad assertion

    @BoxyUwU
    BoxyUwU committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    9df35a5 View commit details
    Browse the repository at this point in the history

  8. move compute_goal and evaluate_x methods to inner module

    @BoxyUwU
    BoxyUwU committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b85bc19 View commit details
    Browse the repository at this point in the history