Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal_features lint #108955

Merged
merged 1 commit into from Aug 4, 2023
Merged

Add internal_features lint #108955

merged 1 commit into from Aug 4, 2023

Commits on Aug 3, 2023

  1. Add internal_features lint

    It lints against features that are inteded to be internal to the
    compiler and standard library. Implements MCP rust-lang#596.
    
    We allow `internal_features` in the standard library and compiler as those
    use many features and this _is_ the standard library from the "internal to the compiler and
    standard library" after all.
    
    Marking some features as internal wasn't exactly the most scientific approach, I just marked some
    mostly obvious features. While there is a categorization in the macro,
    it's not very well upheld (should probably be fixed in another PR).
    
    We always pass `-Ainternal_features` in the testsuite
    About 400 UI tests and several other tests use internal features.
    Instead of throwing the attribute on each one, just always allow them.
    There's nothing wrong with testing internal features^^
    Nilstrieb committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    5830ca2 View commit details
    Browse the repository at this point in the history