Remove f32 & f64 from MemDecoder/MemEncoder #109984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-query-system
scottmcm
force-pushed
the
less-float
branch
2 times, most recently
from
a92833c
to
a9a680d
Compare
|
can you add a reference to this PR so that people can revert it if they need it later (which they probably don't but you never know)? |
|
Sure thing; done. If you're here in the future: you might want to change how this works, because using LEB128 for floats is a poor choice -- even a simple float like Indeed, the only |
|
@bors r=Nilstrieb |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 6, 2023
Remove f32 & f64 from MemDecoder/MemEncoder r? `@Nilstrieb` since they said (maybe joked) on discord that it's a bug if the compiler uses f32 anywhere 🙃
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 6, 2023
Remove f32 & f64 from MemDecoder/MemEncoder r? ``@Nilstrieb`` since they said (maybe joked) on discord that it's a bug if the compiler uses f32 anywhere 🙃
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#109395 (Fix issue when there are multiple candidates for edit_distance_with_substrings) - rust-lang#109755 (Implement support for `GeneratorWitnessMIR` in new solver) - rust-lang#109782 (Don't leave a comma at the start of argument list when removing arguments) - rust-lang#109977 (rustdoc: avoid including line numbers in Google SERP snippets) - rust-lang#109980 (Derive String's PartialEq implementation) - rust-lang#109984 (Remove f32 & f64 from MemDecoder/MemEncoder) - rust-lang#110004 (add `dont_check_failure_status` option in the compiler test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Nilstrieb
since they said (maybe joked) on discord that it's a bug if the compiler uses f32 anywhere 🙃