Delay a good path bug on drop for TypeErrCtxt (instead of a regular delayed bug)
#110476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Does it work if you explicitly Need to check after work. |
|
No, I tried a bunch of combinations and they all seem to not work lol... |
compiler-errors
force-pushed
the
ty-err-ctxt-good-path
branch
from
871e214
to
556062e
Compare
|
r=me with or without a clippy test 🤷 don't have an opinion on whether we should instead completely remove the |
|
oh I see, so the ice happens AFTER the lint is emitted, and since we default to errors, compilation just stops and we simply don't hit the ICE in the tests, weird :/ |
|
ok it's a bit dirty but you force the test to warn via |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 18, 2023
|
If you cherry-pick matthiaskrgr@b1d6e8f into your branch it should work I think :) |
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
Thanks @matthiaskrgr for the test! @bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#110432 (Report more detailed reason why `Index` impl is not satisfied) - rust-lang#110451 (Minor changes to `IndexVec::ensure_contains_elem` & related methods) - rust-lang#110476 (Delay a good path bug on drop for `TypeErrCtxt` (instead of a regular delayed bug)) - rust-lang#110498 (Switch to `EarlyBinder` for `collect_return_position_impl_trait_in_trait_tys`) - rust-lang#110507 (boostrap: print output during building tools) - rust-lang#110510 (Fix ICE for transmutability in candidate assembly) - rust-lang#110513 (make `non_upper_case_globals` lint not report trait impls) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Feb 12, 2024
The check within changed from `delay_span_bug` to `delay_good_path_bug` in rust-lang#110476, and removing the check altogether was considered. It's a very weak sanity check and gets in the way of removing good path delayed bugs altogether, so this PR just removes it.
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Feb 12, 2024
The check within changed from `delay_span_bug` to `delay_good_path_bug` in rust-lang#110476, and removing the check altogether was considered. It's a very weak sanity check and gets in the way of removing good path delayed bugs altogether, so this PR just removes it.
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Feb 13, 2024
The check within changed from `delay_span_bug` to `delay_good_path_bug` in rust-lang#110476, and removing the check altogether was considered. It's a very weak sanity check and gets in the way of removing good path delayed bugs altogether, so this PR just removes it.
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Feb 13, 2024
The check within changed from `delay_span_bug` to `delay_good_path_bug` in rust-lang#110476, and removing the check altogether was considered. It's a very weak sanity check and gets in the way of removing good path delayed bugs altogether, so this PR just removes it.
RustyYato
pushed a commit
to RustyYato/rust
that referenced
this pull request
Jun 2, 2024
The check within changed from `delay_span_bug` to `delay_good_path_bug` in rust-lang#110476, and removing the check altogether was considered. It's a very weak sanity check and gets in the way of removing good path delayed bugs altogether, so this PR just removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @lcnr
Perhaps we should just delete the
Dropimpl altogether though?Fixes rust-lang/rust-clippy#10645
@matthiaskrgr: I don't know how to make a clippy test for this. Any idea? Clippy's UI tests run with
-D warningsand I have no idea how to switch it off to make a test that triggers this ICE in the clippy test suite 🤣