Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize builder sizes #110846

Merged
merged 3 commits into from
May 3, 2023
Merged

Optimize builder sizes #110846

merged 3 commits into from
May 3, 2023

Conversation

jdno
Copy link
Member

@jdno jdno commented Apr 26, 2023

The infra-team is continuously monitoring the efficiency of the CI system in an effort to improve overall build times and resource usage. Some builders have used much less than their allocated resources, so we are testing smaller builder sizes for them.

r? @pietroalbini

@jdno
Downsize builders for i686-gnu
3402e28 
The infra-team is continuously monitoring the efficiency of the build
system in an effort to improve overall build times and resource usage.
The builders for the `i686-gnu` targets have used much less resources
than allocated in the past, so we are testing a smaller builder size for
them.
@jdno
Downsize builder for mingw-check
4cbe65d 
The infra-team is continuously monitoring the efficiency of the build
system in an effort to improve overall build times and resource usage.
The builder for the `mingw-check` target have used much less resources
than allocated in the past, so we are testing a smaller builder size for
it.
@jdno
Downsize builders for some x86_64-gnu targets
47528c0 
The infra-team is continuously monitoring the efficiency of the build
system in an effort to improve overall build times and resource usage.
The builders for some of the `x86_64-gnu` targets have used much less
resources than allocated in the past, so we are testing a smaller
builder size for them.
@rustbot
Copy link
Collaborator

rustbot commented Apr 26, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pietroalbini (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 26, 2023
@jdno jdno changed the title Reduce builder sizes Optimize builder sizes Apr 26, 2023
@pietroalbini
Copy link
Member

...I guess welcome JD? 😂

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 26, 2023

📌 Commit 47528c0 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 26, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 26, 2023
@matthiaskrgr
Rollup merge of rust-lang#110846 - jdno:reduce-builder-sizes, r=pietr…
769e859 
…oalbini

Optimize builder sizes

The infra-team is continuously monitoring the efficiency of the CI system in an effort to improve overall build times and resource usage. Some builders have used much less than their allocated resources, so we are testing smaller builder sizes for them.

r? `@pietroalbini`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 27, 2023
@matthiaskrgr
Rollup merge of rust-lang#110846 - jdno:reduce-builder-sizes, r=pietr…
fb5ef4f 
…oalbini

Optimize builder sizes

The infra-team is continuously monitoring the efficiency of the CI system in an effort to improve overall build times and resource usage. Some builders have used much less than their allocated resources, so we are testing smaller builder sizes for them.

r? ``@pietroalbini``
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 27, 2023
Closed
@matthiaskrgr
Copy link
Member

@bors r- rollup=never
(please dont rollup=always infra changes 😿 )
some builders are not starting up (see rollup)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 27, 2023
@jdno
Copy link
Member Author

jdno commented May 1, 2023

Okay, seems that I messed up the configuration for the new ubuntu-20.04-4core-16gb runners. I didn't put them in the right group, and missed that the default group with scope All repositories doesn't include public repositories. 😬

I moved the new runners into the same group as the existing ones, so everything should work now. 🤞

@pietroalbini
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented May 2, 2023

📌 Commit 47528c0 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2023
@bors
Copy link
Contributor

bors commented May 3, 2023

⌛ Testing commit 47528c0 with merge 82cd953...

@bors
Copy link
Contributor

bors commented May 3, 2023

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 82cd953 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 3, 2023
@bors bors merged commit 82cd953 into rust-lang:master May 3, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 3, 2023
@jdno jdno deleted the reduce-builder-sizes branch May 3, 2023 11:55
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (82cd953): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.6% [1.6%, 1.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.6% [1.6%, 1.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 654.051s -> 654.411s (0.06%)

@matthiaskrgr matthiaskrgr mentioned this pull request Aug 25, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jdno @rustbot @pietroalbini @bors @matthiaskrgr @rust-timer