asm: loongarch64: Implementation of clobber_abi #111237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
3 tasks
heiher
commented
May 5, 2023
| f8, f9, f10, f11, f12, f13, f14, f15, | ||
| f16, f17, f18, f19, f20, f21, f22, f23, | ||
| } | ||
| }, |
There was a problem hiding this comment.
LoongArch Register Convention: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2023
asm: loongarch64: Implementation of clobber_abi r? `@Amanieu`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2023
asm: loongarch64: Implementation of clobber_abi r? ``@Amanieu``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111002 (Fix the test directories suggested by `./x.py suggest`) - rust-lang#111077 (Make more ConstProp tests unit.) - rust-lang#111151 (check bootstrap scripts syntax) - rust-lang#111203 (Output LLVM optimization remark kind in `-Cremark` output) - rust-lang#111237 (asm: loongarch64: Implementation of clobber_abi) - rust-lang#111274 (Expand the LLVM coverage of `--print target-cpus`) - rust-lang#111289 (Check arguments length in trivial diagnostic lint) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Amanieu
reviewed
May 12, 2023
| @@ -880,6 +881,10 @@ impl InlineAsmClobberAbi { | |||
| "C" | "system" | "efiapi" => Ok(InlineAsmClobberAbi::RiscV), | |||
| _ => Err(&["C", "system", "efiapi"]), | |||
| }, | |||
| InlineAsmArch::LoongArch64 => match name { | |||
| "C" | "system" | "efiapi" => Ok(InlineAsmClobberAbi::LoongArch), | |||
There was a problem hiding this comment.
I just noticed this, but this should not include efiapi, which is not a valid ABI on loongarch.
There was a problem hiding this comment.
Thanks for catching that mistake. I'll make the necessary changes.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 13, 2023
asm: loongarch64: Drop efiapi This PR aims to drop `efiapi` which is not a valid ABI on LoongArch. Fixes: rust-lang#111237 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2023
Stabilize inline asm for LoongArch64 This PR is used to tracking for stabilize `inline asm` for LoongArch64. **Status** - [x] rust-lang#111237 - [x] rust-lang#111332 - [ ] rust-lang/reference#1357 Any others I missed? r? `@Amanieu`
saethlin
pushed a commit
to saethlin/miri
that referenced
this pull request
May 30, 2023
Stabilize inline asm for LoongArch64 This PR is used to tracking for stabilize `inline asm` for LoongArch64. **Status** - [x] rust-lang/rust#111237 - [x] rust-lang/rust#111332 - [ ] rust-lang/reference#1357 Any others I missed? r? `@Amanieu`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 20, 2024
Stabilize inline asm for LoongArch64 This PR is used to tracking for stabilize `inline asm` for LoongArch64. **Status** - [x] rust-lang/rust#111237 - [x] rust-lang/rust#111332 - [ ] rust-lang/reference#1357 Any others I missed? r? `@Amanieu`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Stabilize inline asm for LoongArch64 This PR is used to tracking for stabilize `inline asm` for LoongArch64. **Status** - [x] rust-lang/rust#111237 - [x] rust-lang/rust#111332 - [ ] rust-lang/reference#1357 Any others I missed? r? `@Amanieu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Amanieu