CFI: Fix cfi with repr(transparent): transform_ty: unexpected Alias(Proj #112182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? @bjorn3 |
compiler/rustc_symbol_mangling/src/typeid/typeid_itanium_cxx_abi.rs
Outdated
Show resolved
Hide resolved
rcvalle
force-pushed
the
rust-cfi-fix-111185
branch
from
b134e20
to
40630ce
Compare
compiler/rustc_symbol_mangling/src/typeid/typeid_itanium_cxx_abi.rs
Outdated
Show resolved
Hide resolved
Fixes rust-lang#111185 by normalizing ty::Alias before encoding.
rcvalle
force-pushed
the
rust-cfi-fix-111185
branch
from
40630ce
to
faf31b5
Compare
compiler-errors
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
This is fine for now.
It may have some strange interactions with typeid_for_instance, since as I think I've pointed out in a previous PR, it's (probably) not correct to be using the unsubstituted impl trait ref in that PR. But that's not really a blocker on this PR.
|
r? @compiler-errors @bors r+ |
bors
added
S-waiting-on-bors
|
Thank you for your time and for your help on this, @compiler-errors! Much appreciated. (I'll also go back and check what you pointed out in our discussions in the previous PR as soon as I've a chance.) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 2, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#111647 (use c literals in compiler and library) - rust-lang#112165 (Rename `impl_defaultness` to `defaultness`) - rust-lang#112182 (CFI: Fix cfi with repr(transparent): transform_ty: unexpected Alias(Proj) - rust-lang#112189 (Debug-assert that closures and generators are made with the right number of substitutions) - rust-lang#112205 (Add rustdoc test for double-hyphen to dash doc comment conversion) - rust-lang#112206 (Fix typo in `std::cell` module docs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111185 by normalizing ty::Alias before encoding.