Resolve vars in result from scrape_region_constraints
#112196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Jun 2, 2023
| @@ -1,6 +1,6 @@ | |||
| // run-pass | |||
| // If `Index` used an associated type for its output, this test would | |||
There was a problem hiding this comment.
Index does use an associated type in the ... 8? years since this test was written 😁
lcnr
reviewed
Jun 5, 2023
Comment on lines
63
to
64
| Op: super::TypeOp<'tcx, Output = R>, | ||
| R: TypeFoldable<TyCtxt<'tcx>>, |
There was a problem hiding this comment.
can you move that to where bounds instead?
rust-cloud-vms
bot
force-pushed
the
new-solver-resolv
branch
from
1746fbe
to
979379a
Compare
|
moved bounds to where clauses @bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#112081 (Avoid ICE on `#![doc(test(...)]` with literal parameter) - rust-lang#112196 (Resolve vars in result from `scrape_region_constraints`) - rust-lang#112303 (Normalize in infcx instead of globally for `Option::as_deref` suggestion) - rust-lang#112316 (Ensure space is inserted after keyword in `unused_delims`) - rust-lang#112318 (Merge method, type and const object safety checks) - rust-lang#112322 (Don't mention `IMPLIED_BOUNDS_ENTAILMENT` if signatures reference error) Failed merges: - rust-lang#112251 (rustdoc: convert `if let Some()` that always matches to variable) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we perform
type_op::Normalizein the local infcx when the new solver is enabled, vars aren't necessarily resolved, which triggers this ICE:rust/compiler/rustc_infer/src/infer/nll_relate/mod.rs
Line 481 in f85ab54
There are more tests that go from ICE -> pass due to this change, but I just added revisions to a few for CI.
r? @lcnr