Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require TAITs to be mentioned in the signatures of functions that register hidden types for them #112652

Merged
merged 11 commits into from
Jul 8, 2023
Merged

Require TAITs to be mentioned in the signatures of functions that register hidden types for them #112652

merged 11 commits into from
Jul 8, 2023

Commits on Jul 7, 2023

  1. Require TAITs to be mentioned in the signatures of functions that reg… 

    …ister hidden types for them
    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4c99872 View commit details
    Browse the repository at this point in the history

  2. Remove normalization from opaque_types_defined_by

    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    907f97e View commit details
    Browse the repository at this point in the history

  3. We don't need to track binders if we aren't normalizing

    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2f89c96 View commit details
    Browse the repository at this point in the history

  4. liar liar find_taits_declared_in_body on fire

    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a3ca139 View commit details
    Browse the repository at this point in the history

  5. Remove one layer of nested matching on the same thing

    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    af9dcf7 View commit details
    Browse the repository at this point in the history

  6. Move some logic into a method on OpaqueTypeCollector

    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    b07d27c View commit details
    Browse the repository at this point in the history

  7. Collect nested items immediately instead of collecting them into an i… 

    …ntermediate `Vec` first
    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    18f3d86 View commit details
    Browse the repository at this point in the history

  8. Only match on the DefKind once.

    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    dcacfe7 View commit details
    Browse the repository at this point in the history

  9. Add regression test

    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ef52dc7 View commit details
    Browse the repository at this point in the history

  10. Fix one layer of closures not being able to constrain opaque types

    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    b549ba1 View commit details
    Browse the repository at this point in the history

  11. Treat closures as part of their parent

    @oli-obk
    oli-obk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c3004a7 View commit details
    Browse the repository at this point in the history