Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add machine-applicable suggestion for unused_qualifications lint #112729

Merged
merged 1 commit into from Jul 14, 2023
Merged

Add machine-applicable suggestion for unused_qualifications lint #112729

merged 1 commit into from Jul 14, 2023

Conversation

jieyouxu
Copy link
Contributor 

error: unnecessary qualification
  --> $DIR/unused-qualifications-suggestion.rs:17:5
   |
LL |     foo::bar();
   |     ^^^^^^^^
   |
note: the lint level is defined here
  --> $DIR/unused-qualifications-suggestion.rs:3:9
   |
LL | #![deny(unused_qualifications)]
   |         ^^^^^^^^^^^^^^^^^^^^^
help: replace it with the unqualified path
   |
LL |     bar();
   |     ~~~

Closes #92198.

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2023
b-naber
b-naber reviewed Jul 12, 2023
View reviewed changes
compiler/rustc_lint_defs/src/lib.rs Outdated
/// The span of the unnecessarily-qualified path.
path_span: Span,
/// The replacement unqualified path.
unqualified_path: String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use Ident here instead of String. Ident implements ToString.

@jieyouxu jieyouxu force-pushed the unused-qualifications-suggestion branch from 38439b9 to 0b5c683 Compare July 13, 2023 01:11
@b-naber
Copy link
Contributor

b-naber commented Jul 13, 2023

Thanks. And sorry for the very late review.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 13, 2023

📌 Commit 0b5c683 has been approved by b-naber

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 13, 2023
@matthiaskrgr
Rollup merge of rust-lang#112729 - jieyouxu:unused-qualifications-sug…
3f539cd 
…gestion, r=b-naber

Add machine-applicable suggestion for `unused_qualifications` lint

```
error: unnecessary qualification
  --> $DIR/unused-qualifications-suggestion.rs:17:5
   |
LL |     foo::bar();
   |     ^^^^^^^^
   |
note: the lint level is defined here
  --> $DIR/unused-qualifications-suggestion.rs:3:9
   |
LL | #![deny(unused_qualifications)]
   |         ^^^^^^^^^^^^^^^^^^^^^
help: replace it with the unqualified path
   |
LL |     bar();
   |     ~~~
```

Closes rust-lang#92198.
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 13, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 13, 2023
@matthiaskrgr
Rollup merge of rust-lang#112729 - jieyouxu:unused-qualifications-sug…
93563cc 
…gestion, r=b-naber

Add machine-applicable suggestion for `unused_qualifications` lint

```
error: unnecessary qualification
  --> $DIR/unused-qualifications-suggestion.rs:17:5
   |
LL |     foo::bar();
   |     ^^^^^^^^
   |
note: the lint level is defined here
  --> $DIR/unused-qualifications-suggestion.rs:3:9
   |
LL | #![deny(unused_qualifications)]
   |         ^^^^^^^^^^^^^^^^^^^^^
help: replace it with the unqualified path
   |
LL |     bar();
   |     ~~~
```

Closes rust-lang#92198.
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 13, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 13, 2023
@matthiaskrgr
Rollup merge of rust-lang#112729 - jieyouxu:unused-qualifications-sug…
5121f38 
…gestion, r=b-naber

Add machine-applicable suggestion for `unused_qualifications` lint

```
error: unnecessary qualification
  --> $DIR/unused-qualifications-suggestion.rs:17:5
   |
LL |     foo::bar();
   |     ^^^^^^^^
   |
note: the lint level is defined here
  --> $DIR/unused-qualifications-suggestion.rs:3:9
   |
LL | #![deny(unused_qualifications)]
   |         ^^^^^^^^^^^^^^^^^^^^^
help: replace it with the unqualified path
   |
LL |     bar();
   |     ~~~
```

Closes rust-lang#92198.
This was referenced Jul 13, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2023
@bors
Auto merge of rust-lang#113676 - matthiaskrgr:rollup-n01iiy8, r=matth…
7a5814f 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#112525 (Adjustments for RustyHermit)
 - rust-lang#112729 (Add machine-applicable suggestion for `unused_qualifications` lint)
 - rust-lang#113618 (update ancient note)
 - rust-lang#113640 (Make `nodejs` control the default for RustdocJs tests instead of a hard-off switch)
 - rust-lang#113668 (Correct `the` -> `there` typo in items.md)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2cc0453 into rust-lang:master Jul 14, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 14, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-naber b-naber b-naber left review comments

Assignees

@b-naber b-naber

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Lint unused_qualifications should have a machine-applicable suggestion
4 participants
@jieyouxu @rustbot @b-naber @bors