Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change binders from tuple structs to named fields #112786

Merged
merged 2 commits into from
Jun 20, 2023
Merged

change binders from tuple structs to named fields #112786

merged 2 commits into from
Jun 20, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jun 19, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2023

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 19, 2023
Nilstrieb
Nilstrieb approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@Nilstrieb Nilstrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin
Copy link
Member

@bors r=Nilstrieb

@bors
Copy link
Contributor

bors commented Jun 19, 2023

📌 Commit 0ceb7d5 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2023
@bors
Auto merge of rust-lang#112839 - GuillaumeGomez:rollup-jc5nqug, r=Gui…
1b6d4cd 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#112464 (Fix windows `Socket::connect_timeout` overflow)
 - rust-lang#112720 (Rustdoc: search: color item type and reduce size to avoid clashing)
 - rust-lang#112762 (Sort the errors from arguments checking so that suggestions are handled properly)
 - rust-lang#112786 (change binders from tuple structs to named fields)
 - rust-lang#112794 (Fix linker failures when #[global_allocator] is used in a dependency)
 - rust-lang#112819 (Disable feature(unboxed_closures, fn_traits) in weird-exprs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 73496fc into rust-lang:master Jun 20, 2023
11 checks passed
@rustbot rustbot added this to the 1.72.0 milestone Jun 20, 2023
@lcnr lcnr deleted the early-binder branch June 20, 2023 15:53
floriangru added a commit to floriangru/creusot that referenced this pull request Jun 26, 2023
@floriangru
1/3 Updating for nightly-2023-06-25
e1caf6f 
Patches:
* rust-lang/rust#112119
* rust-lang/rust#108293 (partially)
* rust-lang/rust#112786
* rust-lang/rust#112060
* rust-lang/rust#112163
* rust-lang/rust#112238
* rust-lang/rust#112165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nilstrieb Nilstrieb Nilstrieb approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lcnr @rustbot @rust-log-analyzer @WaffleLapkin @bors @Nilstrieb