hir: Add Become expression kind (explicit tail calls experiment)
#112887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
3 tasks
This comment has been minimized.
This comment has been minimized.
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Nilstrieb
reviewed
Jun 21, 2023
rust-cloud-vms
bot
force-pushed
the
become_unuwuable_in_hir
branch
from
247c4cd
to
b03f1bc
Compare
|
r? compiler-errors |
compiler-errors
approved these changes
Jun 22, 2023
| let call_expr_ty = self.check_expr_with_hint(call, ret_ty); | ||
|
|
||
| // N.B. don't coerce here, as tail calls can't support most/all coercions | ||
| // FIXME(explicit_tail_calls): add a diagnostic note that `become` doesn't allow coercions |
There was a problem hiding this comment.
Yeah, this should be very doable in the future!
compiler-errors
added
S-waiting-on-author
rust-cloud-vms
bot
force-pushed
the
become_unuwuable_in_hir
branch
from
b03f1bc
to
e38576a
Compare
|
@bors r=compiler-errors,Nilstrieb |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jun 26, 2023
Merged
|
Finished benchmarking commit (6f8c27a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 662.166s -> 663.81s (0.25%) |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
…, r=compiler-errors,Nilstrieb `hir`: Add `Become` expression kind (explicit tail calls experiment) This adds `hir::ExprKind::Become` alongside ast lowering. During hir-thir lowering we currently lower `become` as `return`, so that we can partially test `become` without ICEing. cc `@scottmcm` r? `@Nilstrieb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
hir::ExprKind::Becomealongside ast lowering. During hir-thir lowering we currently lowerbecomeasreturn, so that we can partially testbecomewithout ICEing.cc @scottmcm
r? @Nilstrieb