Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation for where clause in rustdoc pages #112927

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

GuillaumeGomez
Copy link
Member

Screenshot of the bug:

image

I used this opportunity to clarify the code a bit because some weird things were going on.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 22, 2023
@notriddle
Copy link
Contributor

This is probably fallout from #102842, which changed function formatting, but wasn't intended to change the indentation on structs.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 22, 2023

📌 Commit b858a47 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 22, 2023
…, r=notriddle

Fix indentation for where clause in rustdoc pages

Screenshot of the bug:

![image](https://github.com/rust-lang/rust/assets/3050060/090cfeaa-0edc-46c7-9ea0-e26ac865b2c2)

I used this opportunity to clarify the code a bit because some weird things were going on.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 23, 2023
…, r=notriddle

Fix indentation for where clause in rustdoc pages

Screenshot of the bug:

![image](https://github.com/rust-lang/rust/assets/3050060/090cfeaa-0edc-46c7-9ea0-e26ac865b2c2)

I used this opportunity to clarify the code a bit because some weird things were going on.

r? ``@notriddle``
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 23, 2023
…, r=notriddle

Fix indentation for where clause in rustdoc pages

Screenshot of the bug:

![image](https://github.com/rust-lang/rust/assets/3050060/090cfeaa-0edc-46c7-9ea0-e26ac865b2c2)

I used this opportunity to clarify the code a bit because some weird things were going on.

r? ```@notriddle```
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 23, 2023
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#111747 (Don't structurally resolve during method ambiguity in probe)
 - rust-lang#112704 (slice::from_raw_parts: mention no-wrap-around condition)
 - rust-lang#112927 (Fix indentation for where clause in rustdoc pages)
 - rust-lang#112933 (Avoid `&format` in error message code)
 - rust-lang#112935 (style-guide: Fix typo)
 - rust-lang#112941 (typo)
 - rust-lang#112942 (style-guide: Organizational and editing tweaks (no semantic changes))
 - rust-lang#112944 (style-guide: Add language disclaiming any effects on non-default Rust styles)
 - rust-lang#112948 (Avoid guessing unknown trait implementation in suggestions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3feee9f into rust-lang:master Jun 23, 2023
11 checks passed
@rustbot rustbot added this to the 1.72.0 milestone Jun 23, 2023
@GuillaumeGomez GuillaumeGomez deleted the where-clause-indent branch June 23, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants