-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extract rustc_test_marker attr in test_case #113315
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
r? compiler |
@petrochenkov I noticed that you were the reviewer for #53410. Could you assist in reviewing this PR? |
So, very unfamiliar with this code. But this doesn't seem right to me? The behavior of this code on master seems to change item visibility to public and adds I think this needs at least a bit more explanation for me to feel comfortable. Let's see what @petrochenkov has to say though. |
I also don't understand why this PR generates an additional item. If some built-in macro generates code (AST) visible to other macros as input, then it should set |
Its goal is to prevent the attribute(generated by
I have a question: is this method applicable to the |
Is So I suggest just setting the missing tokens to a new empty token stream and move on, nobody is using |
@bvanjoi any updates on this? |
Closing this as it doesn't provide substantial help. |
Fixes #100263
To prevent ice caused by normal.tokens.as_ref.unwrap(), which attempts to unwrap the
None
generated by attr_name_value_str