Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing clippy tests #113455

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Fix failing clippy tests #113455

merged 1 commit into from
Jul 8, 2023

Conversation

Alexendoo
Copy link
Member

Comments out the C string literals due to #113334

Fixes rust-lang/rust-clippy#11121

Opened against rust-lang/rust in order to unblock #113450

r? @Nilstrieb

Comments out the C string literals due to rust-lang#113334

Fixes rust-lang/rust-clippy#11121
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@Nilstrieb
Copy link
Member

I also just put up a PR up in clippy (that also slightly improves other code in the file) :D
rust-lang/rust-clippy#11122
I verified it locally with cherry-picked eaa5abb0f58fc8a764104e3b1d552e72eac02945 and it passed.
@bors r+ p=20

@bors
Copy link
Contributor

bors commented Jul 7, 2023

📌 Commit cedcd39 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 7, 2023
Fix failing clippy tests

Comments out the C string literals due to rust-lang#113334

Fixes rust-lang/rust-clippy#11121

Opened against `rust-lang/rust` in order to unblock rust-lang#113450

r? `@Nilstrieb`
@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Jul 7, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 7, 2023
Fix failing clippy tests

Comments out the C string literals due to rust-lang#113334

Fixes rust-lang/rust-clippy#11121

Opened against `rust-lang/rust` in order to unblock rust-lang#113450

r? ``@Nilstrieb``
@bors
Copy link
Contributor

bors commented Jul 8, 2023

⌛ Testing commit cedcd39 with merge eee6b31...

@bors
Copy link
Contributor

bors commented Jul 8, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing eee6b31 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 8, 2023
@bors bors merged commit eee6b31 into rust-lang:master Jul 8, 2023
12 checks passed
@rustbot rustbot added this to the 1.72.0 milestone Jul 8, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (eee6b31): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.7% [-1.7%, -1.7%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.5% [-3.0%, -2.2%] 4
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.5% [-3.0%, -2.2%] 4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 655.85s -> 655.621s (-0.03%)

@Mark-Simulacrum Mark-Simulacrum removed beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Jul 8, 2023
@Mark-Simulacrum
Copy link
Member

Dropping beta labels as this made it into 1.72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong number of generic parameters for DefId(2:2695 ~ core[747e]::marker::Copy): [Bad, Bad]
6 participants