add a csky-unknown-linux-gnuabiv2 target #113658

Dirreke · 2023-07-13T14:41:39Z

This is the rustc side changes to support csky based Linux target(csky-unknown-linux-gnuabiv2).

Tier 3 policy:

A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

I pledge to do my best maintaining it.

Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.

This csky section is the arch name and the unknown-linux section is the same as other linux target, and gnuabiv2 is from the cross-compile toolchain of gcc

Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.

I think the explanation in platform support doc is enough to make this aspect clear.

Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.

It's using open source tools only.

The target must not introduce license incompatibilities.

No new license

Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0).

Understood.

The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the tidy tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements.

There are no new dependencies/features required.

Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, rustc built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.

As previously said it's using open source tools only.

"onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are not limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.

There are no such terms present/

Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.

I'm not the reviewer here.

This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.

I'm not the reviewer here.

Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

It supports for std

The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

I have added the documentation, and I think it's clear.

Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.

Understood.

Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.

Understood.

Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.

I believe I didn't break any other target.

In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.

I think there are no such problems in this PR.

rustbot · 2023-07-13T14:41:47Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot · 2023-07-13T14:41:52Z

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

These commits modify compiler targets.
(See the Target Tier Policy.)

bjorn3 · 2023-07-13T15:36:42Z

compiler/rustc_codegen_llvm/src/asm.rs

@@ -261,6 +261,7 @@ impl<'ll, 'tcx> AsmBuilderMethods<'tcx> for Builder<'_, 'll, 'tcx> {
                InlineAsmArch::M68k => {
                    constraints.push("~{ccr}".to_string());
                }
+                InlineAsmArch::CSKY => {} // https://github.com/llvm/llvm-project/blob/8b76aea8d8b1b71f6220bc2845abc749f18a19b7/clang/lib/Basic/Targets/CSKY.h getClobers()


Did you mean this as a TODO?

No, it's finished here. just to indicate that this part of the code comes from here

compiler/rustc_target/src/abi/call/csky.rs

bjorn3 · 2023-07-13T15:41:51Z

library/std/src/sys/personality/gcc.rs

@@ -59,6 +59,9 @@ const UNWIND_DATA_REG: (i32, i32) = (0, 1); // R0, R1 / X0, X1
 #[cfg(target_arch = "m68k")]
 const UNWIND_DATA_REG: (i32, i32) = (0, 1); // D0, D1

+#[cfg(target_arch = "csky")]
+const UNWIND_DATA_REG: (i32, i32) = (0, 1); // R0, R1


Where can I cross-reference the value for this and unwinder_private_data_size against the official compiler?

Also given that libstd isn't supported yet according to the PR description, maybe omit this and the other libstd changes for now?

https://github.com/llvm/llvm-project/blob/28555793b1e58ee2e147ea62de42a9583fadbc5a/llvm/lib/Target/CSKY/CSKYISelLowering.cpp#L1257-L1265

Dirreke · 2023-07-13T15:42:38Z

I'm trying to support std for it with libc PR rust-lang/libc#3301 . When I cross-compile library with stage 1 for csky-unknown-linux-gnuabiv2, I got an error with archiving std as following

linking with `csky-linux-gnuabiv2-gcc` failed: exit status: 1
...
~/Desktop/rust/build/x86_64-unknown-linux-gnu/stage1-std/csky-unknown-linux-gnuabiv2/release/deps/std-ee277483300e5acd.4kbutcv2zm9fsxcp.rcgu.rmeta: file not recognized: File format not recognized

I am not familiar with system related development。

does anyone have some idea for me to locate the issue? Thanks!

src/doc/rustc/src/platform-support/csky-unknown-linux-gnuabiv2.md

bjorn3 · 2023-07-13T15:50:19Z

I'm trying to support std for it with libc PR rust-lang/libc#3301 . When I cross-compile library with stage 1 for csky-unknown-linux-gnuabiv2, I got an error with archiving std as following
linking with `csky-linux-gnuabiv2-gcc` failed: exit status: 1
...
~/Desktop/rust/build/x86_64-unknown-linux-gnu/stage1-std/csky-unknown-linux-gnuabiv2/release/deps/std-ee277483300e5acd.4kbutcv2zm9fsxcp.rcgu.rmeta: file not recognized: File format not recognized
I am not familiar with system related development。

does anyone have some idea for me to locate the issue? Thanks!

To support compiling dynamic libraries you will need to add csky support to the object crate (no need for adding all relocation types. only adding support for emitting the right e_machine for the architecture is necessary.) and then add support for writing csky object files to

rust/compiler/rustc_codegen_ssa/src/back/metadata.rs

Line 180 in 33a2c24

    
           pub(crate) fn create_object_file(sess: &Session) -> Option<write::Object<'static>> {

Or alternatively you can disable dynamic linking support in the target spec to make the build system skip building libstd as dylib.

bors · 2023-07-18T16:39:05Z

☔ The latest upstream changes (presumably #112374) made this pull request unmergeable. Please resolve the merge conflicts.

Dirreke · 2023-07-25T13:22:06Z

Waiting for the new version of gimli-rs/object (gimli-rs/object#561) to be released and rust-lang/libc#3301 to be merged in libc now.

Dirreke · 2023-08-13T08:30:20Z

hi @bjorn3. I posted PR to bump object in rust-lang/ar_archive_writer#7 and rust-lang/thorin#28. And I see @philipc has one for backtrace-rs: rust-lang/backtrace-rs#557.

Could you help to review them?

Dirreke · 2023-08-13T08:33:20Z

r? @bjorn3

src/bootstrap/llvm.rs

Dirreke · 2023-08-14T17:19:29Z

Thanks

bjorn3 · 2023-08-14T17:52:29Z

@bors r+

bors · 2023-08-14T17:52:31Z

📌 Commit 6d9847e has been approved by bjorn3

It is now in the queue for this repository.

bors · 2023-08-14T18:01:12Z

⌛ Testing commit 6d9847e with merge 9581cc165121b3bb231af256b201937de9d44e04...

compiler/rustc_feature/src/active.rs

Co-authored-by: klensy <klensy@users.noreply.github.com>

rust-log-analyzer · 2023-08-14T18:18:53Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bjorn3 · 2023-08-14T18:25:01Z

@bors r+

bors · 2023-08-14T18:25:03Z

📌 Commit ded88c6 has been approved by bjorn3

It is now in the queue for this repository.

bors · 2023-08-14T21:53:30Z

⌛ Testing commit ded88c6 with merge 180dffb...

bors · 2023-08-14T23:43:43Z

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 180dffb to master...

rust-timer · 2023-08-15T01:18:08Z

Finished benchmarking commit (180dffb): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.3%, 1.9%]	3
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.2%]	4
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	4
All ❌✅ (primary)	0.4%	[-0.3%, 1.9%]	7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.4%, 3.5%]	2
Regressions ❌ (secondary)	2.8%	[0.9%, 4.9%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	2.9%	[2.4%, 3.5%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.463s -> 633.919s (0.23%)
Artifact size: 346.46 MiB -> 346.73 MiB (0.08%)

add initial support for csky-unknown-linux-gnuabiv2 Add libc-files to allow rust to be used on the csky/linux platform with a PR rust-lang/rust#113658 for rust Signed-off-by: [`@Dirreke](https://github.com/Dirreke)` [mingyang_ge@163.com](mingyang_ge@163.com)

rylev · 2023-08-22T16:47:54Z

The perf result is noise.

@rustbot label: +perf-regression-triaged

Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431) Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * For an external LLVM, set dependency of llvm >= 15, in accordance with the upstream changes. * Add a patch with a backport from LLVM 17.0.3 fixing codegen for PPC, ref. rust-lang/rust#116845 Upstream changes: Version 1.73.0 (2023-10-05) ========================== Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431 Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitiv e.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Misc ---- Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

rustbot assigned wesleywiser Jul 13, 2023

Dirreke mentioned this pull request Jul 13, 2023

add initial support for csky-unknown-linux-gnuabiv2 rust-lang/libc#3301

Merged

This comment has been minimized.

Sign in to view

bjorn3 reviewed Jul 13, 2023

View reviewed changes

compiler/rustc_target/src/abi/call/csky.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Jul 13, 2023

View reviewed changes

src/doc/rustc/src/platform-support/csky-unknown-linux-gnuabiv2.md Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Dirreke force-pushed the csky-unknown-linux-gunabiv2 branch from 37cd9c7 to 6a06225 Compare July 19, 2023 15:35

This comment has been minimized.

Sign in to view

rustbot assigned bjorn3 and unassigned wesleywiser Aug 13, 2023

nikic reviewed Aug 13, 2023

View reviewed changes

src/bootstrap/llvm.rs Outdated Show resolved Hide resolved

bjorn3 mentioned this pull request Aug 13, 2023

Bump object to 0.32.0 rust-lang/ar_archive_writer#7

Merged

This comment has been minimized.

Sign in to view

update Cargo.lock

6d9847e

klensy reviewed Aug 14, 2023

View reviewed changes

compiler/rustc_feature/src/active.rs Outdated Show resolved Hide resolved

Update compiler/rustc_feature/src/active.rs

ded88c6

Co-authored-by: klensy <klensy@users.noreply.github.com>

Dirreke mentioned this pull request Aug 14, 2023

Add support for csky nix-rust/nix#2096

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 14, 2023

bors merged commit 180dffb into rust-lang:master Aug 14, 2023
12 checks passed

rustbot added this to the 1.73.0 milestone Aug 14, 2023

cuviper mentioned this pull request Aug 14, 2023

Upgrade std to gimli 0.28.0 #114825

Merged

rustbot added the perf-regression Performance regression. label Aug 15, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 22, 2023

Dirreke mentioned this pull request Sep 19, 2023

Segmentation fault when formatting u128 on aarch64 GNU/Linux #102196

Open

Urgau mentioned this pull request Oct 4, 2023

Bump bootstrap compiler to just-released beta #116407

Merged

This was referenced Oct 20, 2023

[CSKY] segmentation fault in __multi3 llvm/llvm-project#68971

Closed

wrong define of 128-bit related functions like __multi3 and __floatuntidf on csky rust-lang/compiler-builtins#551

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a csky-unknown-linux-gnuabiv2 target #113658

add a csky-unknown-linux-gnuabiv2 target #113658

Dirreke commented Jul 13, 2023 •

edited

rustbot commented Jul 13, 2023

rustbot commented Jul 13, 2023

This comment has been minimized.

bjorn3 Jul 13, 2023

Dirreke Jul 13, 2023

bjorn3 Jul 13, 2023

bjorn3 Jul 13, 2023 •

edited

Dirreke Jul 19, 2023

Dirreke commented Jul 13, 2023

bjorn3 commented Jul 13, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Jul 18, 2023

This comment has been minimized.

This comment has been minimized.

Dirreke commented Jul 25, 2023 •

edited

Dirreke commented Aug 13, 2023 •

edited

Dirreke commented Aug 13, 2023

This comment has been minimized.

Dirreke commented Aug 14, 2023 •

edited

This comment has been minimized.

bjorn3 commented Aug 14, 2023

bors commented Aug 14, 2023

bors commented Aug 14, 2023

rust-log-analyzer commented Aug 14, 2023

bjorn3 commented Aug 14, 2023

bors commented Aug 14, 2023

bors commented Aug 14, 2023

bors commented Aug 14, 2023

rust-timer commented Aug 15, 2023

rylev commented Aug 22, 2023

add a csky-unknown-linux-gnuabiv2 target #113658

add a csky-unknown-linux-gnuabiv2 target #113658

Conversation

Dirreke commented Jul 13, 2023 • edited

rustbot commented Jul 13, 2023

rustbot commented Jul 13, 2023

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bjorn3 Jul 13, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dirreke commented Jul 13, 2023

bjorn3 commented Jul 13, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Jul 18, 2023

This comment has been minimized.

This comment has been minimized.

Dirreke commented Jul 25, 2023 • edited

Dirreke commented Aug 13, 2023 • edited

Dirreke commented Aug 13, 2023

This comment has been minimized.

Dirreke commented Aug 14, 2023 • edited

This comment has been minimized.

bjorn3 commented Aug 14, 2023

bors commented Aug 14, 2023

bors commented Aug 14, 2023

rust-log-analyzer commented Aug 14, 2023

bjorn3 commented Aug 14, 2023

bors commented Aug 14, 2023

bors commented Aug 14, 2023

bors commented Aug 14, 2023

rust-timer commented Aug 15, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

rylev commented Aug 22, 2023

Dirreke commented Jul 13, 2023 •

edited

bjorn3 Jul 13, 2023 •

edited

Dirreke commented Jul 25, 2023 •

edited

Dirreke commented Aug 13, 2023 •

edited

Dirreke commented Aug 14, 2023 •

edited