Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the first LLVM without LTO in try builds #113779

Merged
merged 1 commit into from Jul 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/tools/opt-dist/src/environment/linux.rs
Expand Up @@ -41,6 +41,10 @@ impl Environment for LinuxEnvironment {
true
}

fn supports_shared_llvm(&self) -> bool {
true
}

fn executable_extension(&self) -> &'static str {
""
}
Expand Down
2 changes: 2 additions & 0 deletions src/tools/opt-dist/src/environment/mod.rs
Expand Up @@ -60,6 +60,8 @@ pub trait Environment {

fn supports_bolt(&self) -> bool;

fn supports_shared_llvm(&self) -> bool;

/// What is the extension of binary executables in this environment?
fn executable_extension(&self) -> &'static str;

Expand Down
4 changes: 4 additions & 0 deletions src/tools/opt-dist/src/environment/windows.rs
Expand Up @@ -65,6 +65,10 @@ impl Environment for WindowsEnvironment {
false
}

fn supports_shared_llvm(&self) -> bool {
false
}

fn executable_extension(&self) -> &'static str {
".exe"
}
Expand Down
10 changes: 10 additions & 0 deletions src/tools/opt-dist/src/exec.rs
Expand Up @@ -139,6 +139,16 @@ impl Bootstrap {
self
}

pub fn without_llvm_lto(mut self) -> Self {
self.cmd = self
.cmd
.arg("--set")
.arg("llvm.thin-lto=false")
.arg("--set")
.arg("llvm.link-shared=true");
self
}

pub fn rustc_pgo_optimize(mut self, profile: &RustcPGOProfile) -> Self {
self.cmd = self.cmd.arg("--rust-profile-use").arg(profile.0.as_str());
self
Expand Down
12 changes: 11 additions & 1 deletion src/tools/opt-dist/src/main.rs
Expand Up @@ -38,7 +38,17 @@ fn execute_pipeline(
let rustc_profile_dir_root = env.opt_artifacts().join("rustc-pgo");

stage.section("Build PGO instrumented rustc and LLVM", |section| {
Bootstrap::build(env).rustc_pgo_instrument(&rustc_profile_dir_root).run(section)
let mut builder = Bootstrap::build(env).rustc_pgo_instrument(&rustc_profile_dir_root);

if env.supports_shared_llvm() {
// This first LLVM that we build will be thrown away after this stage, and it
// doesn't really need LTO. Without LTO, it builds in ~1 minute thanks to sccache,
// with LTO it takes almost 10 minutes. It makes the followup Rustc PGO
// instrumented/optimized build a bit slower, but it seems to be worth it.
builder = builder.without_llvm_lto();
}

builder.run(section)
})?;

let profile = stage
Expand Down