Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide ToString implementations that specialize the default one #114020

Merged
merged 1 commit into from Jul 25, 2023

Conversation

steffahn
Copy link
Member

The status quo is highly confusing, since the overlap is not apparent, and specialization is not a feature of Rust. This change addresses #87545; I'm not certain if it closes/fixes it entirely, since that issue might also be tracking the question of a general solution for hiding the documentation for specializing impls automatically.

Before
Screenshot_20230724_234210

After
Screenshot_20230724_234255

The status quo is highly confusing, since the overlap is not apparent,
and specialization is not a feature of Rust. This addresses rust-lang#87545;
I'm not certain if it closes it, since that issue might also be trackign
a *general* solution for hiding specializing impls automatically.
@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 24, 2023
@steffahn steffahn changed the title Hide ToString implementations that specialize the default ones Hide ToString implementations that specialize the default one Jul 24, 2023
@thomcc
Copy link
Member

thomcc commented Jul 24, 2023

Seems like an improvement. I think we might want to discuss it in a t-libs meeting if we want to do this universally.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 24, 2023

📌 Commit 3911a63 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2023
@bors
Copy link
Contributor

bors commented Jul 25, 2023

⌛ Testing commit 3911a63 with merge c026d6a...

@bors
Copy link
Contributor

bors commented Jul 25, 2023

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing c026d6a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2023
@bors bors merged commit c026d6a into rust-lang:master Jul 25, 2023
12 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 25, 2023
@steffahn steffahn deleted the hide-specialized-ToString-impls branch July 25, 2023 12:44
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c026d6a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [2.8%, 3.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.5% [-1.5%, -1.5%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.538s -> 649.334s (-0.19%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants