interpret: make read/write methods generic

[RalfJung]

Instead of always having to call into() to convert things to PlaceTy/OpTy, make the relevant methods generic. This also means that when we read from an MPlaceTy, we avoid creating an intermediate PlaceTy.

This makes it feasible to remove the Copy from MPlaceTy. All the other *Ty interpreter types already had their Copy removed a while ago so this is only consistent. (And in fact we had one function that accidentally took MPlaceTy instead of &MPlaceTy.)

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[RalfJung]

@bors try @rust-timer queue

[bors]

⌛ Trying commit da3f0d0 with merge 738bde30e78de08f74c5b5bdb48306ca11d06d90...

[bors]

☀️ Try build successful - checks-actions
Build commit: 738bde30e78de08f74c5b5bdb48306ca11d06d90 (738bde30e78de08f74c5b5bdb48306ca11d06d90)

[rust-timer]

Finished benchmarking commit (738bde30e78de08f74c5b5bdb48306ca11d06d90): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.1%, -1.6%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[3.2%, 3.2%]	1
Regressions ❌ (secondary)	3.6%	[3.6%, 3.6%]	1
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[-2.1%, 3.2%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[2.3%, 6.1%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.6%	[-7.9%, -7.3%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.593s -> 650.759s (0.03%)

[oli-obk]

@bors r+

[bors]

📌 Commit 12b9c96c9ea960060072fc01d802b6430a0f59be has been approved by oli-obk

It is now in the queue for this repository.

[RalfJung]

Found some more unnecessary &mut around valtree_into_mplace

@bors r=oli-obk

[bors]

📌 Commit 571e8ce has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 571e8ce with merge bd9785c...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing bd9785c to master...

[rust-timer]

Finished benchmarking commit (bd9785c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.1%, -1.7%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[2.6%, 2.6%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.6%	[-8.5%, -1.8%]	10
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.097s -> 650.721s (0.10%)