Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effects: don't print host param in diagnostics #114203

Merged
merged 1 commit into from Jul 30, 2023
Merged

Effects: don't print host param in diagnostics #114203

merged 1 commit into from Jul 30, 2023

Conversation

fee1-dead
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 29, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jul 29, 2023

Could be useful to keep printing them under -Zverbose. Or do you think it will always be obvious enough?

@fee1-dead
Copy link
Member Author

Oh yea this was cherry picked from my old code. At some point I changed it to still print with -Zverbose but it didn't carry to this PR I guess. Will do that once I get time

@fee1-dead fee1-dead mentioned this pull request Jul 29, 2023
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Jul 30, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 30, 2023

📌 Commit df3f9fd has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023
@fee1-dead fee1-dead mentioned this pull request Jul 30, 2023
Closed
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jul 30, 2023
@fee1-dead
Rollup merge of rust-lang#114203 - fee1-dead-contrib:effects/pp-no-ho…
a3b8bf5 
…st, r=oli-obk

Effects: don't print `host` param in diagnostics

r? `@oli-obk`
@fee1-dead fee1-dead mentioned this pull request Jul 30, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2023
@bors
Auto merge of rust-lang#114236 - fee1-dead-contrib:rollup-m92j7q1, r=…
4c9ac1e 
…fee1-dead

Rollup of 3 pull requests

Successful merges:

 - rust-lang#112151 (Clarify behavior of inclusive bounds in BTreeMap::{lower,upper}_bound)
 - rust-lang#113512 (Updated lines doc to include trailing carriage return note)
 - rust-lang#114203 (Effects: don't print `host` param in diagnostics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7b4bfd6 into rust-lang:master Jul 30, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 30, 2023
@fee1-dead fee1-dead deleted the effects/pp-no-host branch July 30, 2023 14:16
@fee1-dead fee1-dead mentioned this pull request Sep 11, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fee1-dead @oli-obk @bors @rustbot