Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x64 Linux host compiler to LLVM 17 #114297

Merged
merged 1 commit into from Aug 24, 2023
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 31, 2023

This PR updates the LLVM host compiler on 64-bit Linux to version 17.

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 31, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 31, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 31, 2023
@bors
Copy link
Contributor

bors commented Jul 31, 2023

⌛ Trying commit 40fd427833af056b248d3de730ba41b02960dc79 with merge 79e8cd82e9ff942bc98ff349bba41b89bba6fd5e...

@bors
Copy link
Contributor

bors commented Jul 31, 2023

☀️ Try build successful - checks-actions
Build commit: 79e8cd82e9ff942bc98ff349bba41b89bba6fd5e (79e8cd82e9ff942bc98ff349bba41b89bba6fd5e)

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as outdated.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 1, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented Aug 1, 2023

Huh. So either by switching the repo LLVM to 17 fixed the issue, or the 17.0.0-rc1 tag is actually fine. I'll wait until the move to LLVM 17 is finished and then try again.

@Kobzol
Copy link
Contributor Author

Kobzol commented Aug 1, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 1, 2023
@bors
Copy link
Contributor

bors commented Aug 1, 2023

⌛ Trying commit c5ded39504c39cf4cf3f0a4fd9ce987dd52181f2 with merge 846ecf69b7aff4f2f16616d28667d35c12c70aff...

@bors
Copy link
Contributor

bors commented Aug 1, 2023

☀️ Try build successful - checks-actions
Build commit: 846ecf69b7aff4f2f16616d28667d35c12c70aff (846ecf69b7aff4f2f16616d28667d35c12c70aff)

1 similar comment
@bors
Copy link
Contributor

bors commented Aug 1, 2023

☀️ Try build successful - checks-actions
Build commit: 846ecf69b7aff4f2f16616d28667d35c12c70aff (846ecf69b7aff4f2f16616d28667d35c12c70aff)

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as outdated.

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 1, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented Aug 1, 2023

@bors try @rust-timer queue

Trying to use our own built llvm-profdata for merging rustc PGO profiles.

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 1, 2023
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 23, 2023
@bors
Copy link
Contributor

bors commented Aug 23, 2023

⌛ Trying commit 9cabc91 with merge 217c2852279cd1c70e4963b8d9b0d6464a64c3f8...

@bors
Copy link
Contributor

bors commented Aug 23, 2023

☀️ Try build successful - checks-actions
Build commit: 217c2852279cd1c70e4963b8d9b0d6464a64c3f8 (217c2852279cd1c70e4963b8d9b0d6464a64c3f8)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (217c2852279cd1c70e4963b8d9b0d6464a64c3f8): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.9%, -0.2%] 40
Improvements ✅
(secondary)
-0.9% [-1.4%, -0.2%] 20
All ❌✅ (primary) -0.5% [-0.9%, -0.2%] 40

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.5% [-1.8%, -1.2%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.7% [-4.9%, -0.6%] 11
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) -2.7% [-4.9%, -0.6%] 11

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.819s -> 633.222s (-0.41%)
Artifact size: 347.15 MiB -> 316.34 MiB (-8.87%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 23, 2023
@nikic
Copy link
Contributor

nikic commented Aug 23, 2023

The verifier failure should be fixed in rc3, let's see if anything else turns up...

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Aug 23, 2023

📌 Commit 9cabc91 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2023
@bors
Copy link
Contributor

bors commented Aug 24, 2023

⌛ Testing commit 9cabc91 with merge d795c09554f79c77a76e0981f92436186203ae9d...

@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
---- [ui] tests/ui/associated-type-bounds/fn-inline.rs stdout ----

error: test run failed!
status: exit status: 101
command: RUST_TEST_THREADS="8" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "1" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-type-bounds/fn-inline/a" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-type-bounds/fn-inline/auxiliary/libfn_aux.so"
--- stderr -------------------------------
--- stderr -------------------------------
thread 'main' panicked at 'io::copy(&mut file, dst) failed with Connection reset by peer (os error 104)', src/tools/remote-test-client/src/main.rs:353:5
------------------------------------------



@bors
Copy link
Contributor

bors commented Aug 24, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 24, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented Aug 24, 2023

@bors retry

Looks spurious.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2023
@bors
Copy link
Contributor

bors commented Aug 24, 2023

⌛ Testing commit 9cabc91 with merge 0b31792...

@bors
Copy link
Contributor

bors commented Aug 24, 2023

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 0b31792 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 24, 2023
@bors bors merged commit 0b31792 into rust-lang:master Aug 24, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 24, 2023
@Kobzol Kobzol deleted the llvm-17-host branch August 24, 2023 10:06
@Kobzol
Copy link
Contributor Author

Kobzol commented Aug 24, 2023

@nikic Thanks for pushing this through!

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0b31792): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-1.0%, -0.2%] 41
Improvements ✅
(secondary)
-0.9% [-1.5%, -0.2%] 22
All ❌✅ (primary) -0.6% [-1.0%, -0.2%] 41

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [0.8%, 2.0%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.8% [-1.8%, -1.8%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.241s -> 629.756s (-0.24%)
Artifact size: 346.61 MiB -> 315.78 MiB (-8.89%)

lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
Use the correct `llvm-profdata` binary in `opt-dist`

Turns out that we were probably using the wrong `llvm-profdata` binary in the PGO script all along. This should resolve the performance regressions of switching the host LLVM to 17 ([host `llvm-profdata`](rust-lang/rust#114297 (comment)), [target `llvm-profdata`](rust-lang/rust#114297 (comment))]).

r? `@nikic`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
Use the correct `llvm-profdata` binary in `opt-dist`

Turns out that we were probably using the wrong `llvm-profdata` binary in the PGO script all along. This should resolve the performance regressions of switching the host LLVM to 17 ([host `llvm-profdata`](rust-lang/rust#114297 (comment)), [target `llvm-profdata`](rust-lang/rust#114297 (comment))]).

r? `@nikic`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants