Avoid invalid NaN lint machine-applicable suggestion in const context #114486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
I wonder if we should just see what's blocking stabilizing |
|
Well in that case, shouldn't we just be suggesting nothing? I don't think turning this into a help that still tells folks to use the same fn is the right solution. |
Urgau
force-pushed
the
const-context-nan-suggestion-114471
branch
from
cc264a1
to
b71f2be
Compare
|
It's a bit unsatisfying to not have any suggestion for const context, but I agree, better suggest nothing than suggest functions that have no plan to stabilization in the short or medium term. Updated the PR to completely remove the suggestion. |
compiler-errors
approved these changes
Aug 6, 2023
| e: &hir::Expr<'_>, | ||
| l: &hir::Expr<'_>, | ||
| r: &hir::Expr<'_>, | ||
| f: impl FnOnce(Span, Span) -> InvalidNanComparisonsSuggestion, | ||
| ) -> InvalidNanComparisons { | ||
| let suggestion = | ||
| let suggestion = (!cx.tcx.hir().is_inside_const_context(e.hir_id)).then(|| { |
There was a problem hiding this comment.
nit: this is a somewhat confusing way of avoiding an if statement 😅
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 6, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#114486 (Avoid invalid NaN lint machine-applicable suggestion in const context) - rust-lang#114503 (Remove invalid lint when there is a generic argument in prefix path) - rust-lang#114509 (Migrate GUI colors test to original CSS color format) - rust-lang#114524 (Also ICE when goals go from Ok to Err in new solver) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the machine-applicable suggestion in const context for the
invalid_nan_comparisionlintand replace it with a simple help.Fixes #114471