Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From<&'a &'static str> for Arguments<'a> #114531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EFanZh
Copy link
Contributor

@EFanZh EFanZh commented Aug 6, 2023

Provides a way to construct an Arguments object from an &'static str object, and calling as_str on the result object will return Some(&'static str).

ACP: rust-lang/lib-team#257.

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 6, 2023
@rust-log-analyzer

This comment has been minimized.

@EFanZh EFanZh force-pushed the implement-from-str-for-arguments branch from 99620b3 to 153c2e4 Compare August 6, 2023 10:09
@dtolnay dtolnay assigned dtolnay and unassigned joshtriplett Sep 16, 2023
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Based on rust-lang/libs-team#257 (comment), I believe this is currently blocked while we work to figure out whether #115129 is going to be landable.

@dtolnay dtolnay added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants