Improve invalid_reference_casting lint
#114784
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Urgau
force-pushed
the
many-improve-invalid_reference_casting-lint
branch
from
5cb4dde
to
7c8dc1d
Compare
This comment has been minimized.
This comment has been minimized.
Urgau
force-pushed
the
many-improve-invalid_reference_casting-lint
branch
2 times, most recently
from
edebb8a
to
6ed59b7
Compare
| @@ -112,6 +112,7 @@ impl<T: ?Sized> *mut T { | |||
| /// [`cast_mut`]: #method.cast_mut | |||
| #[stable(feature = "ptr_const_cast", since = "1.65.0")] | |||
| #[rustc_const_stable(feature = "ptr_const_cast", since = "1.65.0")] | |||
| #[rustc_diagnostic_item = "ptr_cast_const"] | |||
There was a problem hiding this comment.
I think there is high confusion potential between ptr_const_cast and ptr_cast_const. Maybe this one could be renamed to ptr_mut_cast_const?
There was a problem hiding this comment.
I decided to rename the other one from ptr_const_cast to const_ptr_cast, so that every diagnostic item finishes with the name of it's method.
There was a problem hiding this comment.
I think that rename improved the situation but the two names are still only distinguished by the order of the components. I think the mut should still be added to this one.
There was a problem hiding this comment.
Except that the const part is now on the opposite side of the word: in front for const_ptr_cast and behind for ptr_cast_const, there is still the possibility that someone might mistake one for the other, but I think it's sufficiently diffused.
PS: I'm not against changing it, but I think adding mut would make the name out of place, and could definitely confuse a future me.
There was a problem hiding this comment.
Mhh yeah the other names are also not prefixed with mut_, even though IMO they should be. I will approve this.
Urgau
force-pushed
the
many-improve-invalid_reference_casting-lint
branch
from
6ed59b7
to
91b05f8
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
…ce_casting-lint, r=est31 Improve `invalid_reference_casting` lint This PR improves the `invalid_reference_casting` lint: - by considering an unlimited number of casts instead only const to mut ptr - by also considering ptr-to-integer and integer-to-ptr casts - by also taking into account [`ptr::cast`](https://doc.rust-lang.org/std/primitive.pointer.html#method.cast), [`ptr::cast`](https://doc.rust-lang.org/std/primitive.pointer.html#method.cast-1) and [`ptr::cast_const`](https://doc.rust-lang.org/std/primitive.pointer.html#method.cast_const) Most of this improvements comes from skimming Github Code Search result for [`&mut \*.*as \*const`](https://github.com/search?q=lang%3Arust+%2F%26mut+%5C*.*as+%5C*const%2F&type=code) r? `@est31` (maybe)
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#113115 (we are migrating to askama) - rust-lang#114784 (Improve `invalid_reference_casting` lint) - rust-lang#114822 (Improve code readability by moving fmt args directly into the string) - rust-lang#114878 (rustc book: make more pleasant to search) - rust-lang#114899 (Add missing Clone/Debug impls to SMIR Trait related tys) r? `@ghost` `@rustbot` modify labels: rollup
This PR improves the
invalid_reference_castinglint:ptr::cast,ptr::castandptr::cast_constMost of this improvements comes from skimming Github Code Search result for
&mut \*.*as \*constr? @est31 (maybe)