Couple of global state and driver refactors #114803
Conversation
It was only ever set in a function which isn't called anywhere.
All of them are not exported from rustc_interface and used only during global_ctxt(). Inlining them makes it easier to follow the order of queries and slightly reduces line count.
Constructing an FxIndexMap is useless work as the iteration order never matters.
It is only used by CrateLoader. We can store the metadata loader in CStore instead which CrateLoader has access to.
|
r? @fee1-dead (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-query-system
| @@ -1455,18 +1454,6 @@ pub(crate) fn make_unclosed_delims_error( | |||
| Some(err) | |||
| } | |||
|
|
|||
| pub fn emit_unclosed_delims(unclosed_delims: &mut Vec<UnmatchedDelim>, sess: &ParseSess) { | |||
There was a problem hiding this comment.
can we use some check in tidy to find this kind of unused functions?
@jyn514
There was a problem hiding this comment.
Tidy can't, https://github.com/est31/warnalyzer can, in some cases. But save-analysis was removed so it became harder work.
|
@bors r=fee1-dead |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (ffaa32b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 633.466s -> 632.706s (-0.12%) |
TyCtxtqueries)FxIndexMap