Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not compute unneeded query results. #114908

Merged
merged 1 commit into from Aug 30, 2023
Merged

Conversation

cjgillot
Copy link
Contributor

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 16, 2023
@rust-log-analyzer

This comment has been minimized.

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2023
@bors
Copy link
Contributor

bors commented Aug 16, 2023

⌛ Trying commit d1cfc15a7fb100e7073865a2d86909acec8127c2 with merge 07c3aaaaea0653f257675bd4499cda3ae969fcf7...

@bors
Copy link
Contributor

bors commented Aug 16, 2023

☀️ Try build successful - checks-actions
Build commit: 07c3aaaaea0653f257675bd4499cda3ae969fcf7 (07c3aaaaea0653f257675bd4499cda3ae969fcf7)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (07c3aaaaea0653f257675bd4499cda3ae969fcf7): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
-1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.164s -> 633.634s (-0.24%)
Artifact size: 346.71 MiB -> 346.81 MiB (0.03%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 17, 2023
@cjgillot cjgillot marked this pull request as ready for review August 24, 2023 17:10
@cjgillot
Copy link
Contributor Author

r? compiler

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 30, 2023

📌 Commit 023b367 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2023
@bors
Copy link
Contributor

bors commented Aug 30, 2023

⌛ Testing commit 023b367 with merge 82c2eb4...

@bors
Copy link
Contributor

bors commented Aug 30, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 82c2eb4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 30, 2023
@bors bors merged commit 82c2eb4 into rust-lang:master Aug 30, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 30, 2023
@cjgillot cjgillot deleted the no-let-under branch August 30, 2023 06:48
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (82c2eb4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.0% [2.0%, 4.0%] 2
Improvements ✅
(primary)
-1.0% [-1.2%, -0.7%] 2
Improvements ✅
(secondary)
-0.9% [-0.9%, -0.9%] 1
All ❌✅ (primary) -1.0% [-1.2%, -0.7%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.9% [-5.5%, -0.8%] 7
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.9% [-5.5%, -0.8%] 7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.341s -> 630.718s (-0.10%)
Artifact size: 316.61 MiB -> 316.56 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants