New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dummy PR to test coverage test changes in CI #114917
base: master
Are you sure you want to change the base?
Conversation
@rustbot experimental |
@rustbot author |
77baf81
to
4363ce9
Compare
Now testing #114843 in CI on Linux/Windows/macOS, to ensure I don't get any nasty surprises after it's reviewed. |
Success: |
☔ The latest upstream changes (presumably #115183) made this pull request unmergeable. Please resolve the merge conflicts. |
b605cc7
to
c4511d7
Compare
Testing #114843 on Linux/Windows/macOS ( |
This comment has been minimized.
This comment has been minimized.
c4511d7
to
188b788
Compare
Those Linux failures look like the same ones I saw on the I'm going to try another run of Windows only, to flush out any unknown issues on that platform. |
This comment has been minimized.
This comment has been minimized.
Test failures on Windows seem to be the same as the Linux ones, which is surprising. Perhaps there is some common property of the main Linux/Windows CI environments that is not shared by |
188b788
to
f3ae5a0
Compare
I'll try a CI macOS build to double check all the major platforms. |
This comment has been minimized.
This comment has been minimized.
Hmm, so the overall results so far seem to be: Failure (probably the same failures, though I haven't fully verified this):
Success:
|
f3ae5a0
to
ef88666
Compare
Trying another build with the default PR CI config ( |
This comment has been minimized.
This comment has been minimized.
ef88666
to
8f31d25
Compare
This comment has been minimized.
This comment has been minimized.
44b40b7
to
4a227b4
Compare
Testing some details of #119034 in advance. |
This comment has been minimized.
This comment has been minimized.
4a227b4
to
17df0f0
Compare
This comment has been minimized.
This comment has been minimized.
As expected, the test does fail on Windows, so it's correct to |
☔ The latest upstream changes (presumably #119621) made this pull request unmergeable. Please resolve the merge conflicts. |
17df0f0
to
cf2284d
Compare
Testing out a port of |
This comment has been minimized.
This comment has been minimized.
cf2284d
to
7b475c8
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #120881) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #121904) made this pull request unmergeable. Please resolve the merge conflicts. |
6e72e22
to
6ceceb8
Compare
Testing whether I can remove |
Looks like the test passed on Windows: https://github.com/rust-lang/rust/actions/runs/8295637584/job/22703073495?pr=114917 Might as well try mingw as well, since that supposedly has problems with the profiler runtime. |
6ceceb8
to
9a60cc0
Compare
x86_64-mingw seems fine too: https://github.com/rust-lang/rust/actions/runs/8303600151/job/22727987597?pr=114917 |
9a60cc0
to
0ec58eb
Compare
This comment has been minimized.
This comment has been minimized.
OK, I think the reason This suggests that maybe we should stop building the profiler runtime on windows-gnu, and compensate by migrating various existing tests from |
0ec58eb
to
e96a0ab
Compare
☔ The latest upstream changes (presumably #122690) made this pull request unmergeable. Please resolve the merge conflicts. |
e96a0ab
to
4a50e2b
Compare
☔ The latest upstream changes (presumably #123451) made this pull request unmergeable. Please resolve the merge conflicts. |
The
x86_64-gnu-llvm-15
job that normally runs on PRs doesn't include the profiler runtime, so most of the coverage tests don't get run on PRs.(That's why #114875 didn't fail until an actual merge was attempted.)
r? @ghost