Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Windows platform support #115141

Merged
merged 1 commit into from Mar 12, 2024
Merged

Update Windows platform support #115141

merged 1 commit into from Mar 12, 2024

Conversation

ChrisDenton
Copy link
Contributor

This should not be merged until Rust 1.76 but I'm told this may need an fcp in addition to MCP 651.

cc @rust-lang/compiler @rust-lang/release

@rustbot
Copy link
Collaborator

rustbot commented Aug 23, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2023
@ChrisDenton ChrisDenton added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. T-release Relevant to the release subteam, which will review and decide on the PR/issue. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Aug 23, 2023
@compiler-errors
Copy link
Member

Similarly to #104385 (comment), should this be a T-libs + T-compiler FCP, rather than T-compiler + T-release? I don't actually think we have a policy around bumping minimum support.

@ChrisDenton
Copy link
Contributor Author

I have no idea. I'd really love to have some clarity on the procedure.

@cuviper
Copy link
Member

cuviper commented Aug 23, 2023 •
edited

The current target policy says:

Raising the baseline expectations of a tier 1 target (such as the minimum CPU features or OS version required) requires the approval of the compiler and release teams, and should be widely communicated as well, but does not necessarily require a full RFC.

(I'm not opposed to including T-libs, just quoting what we have.)

@ehuss
Copy link
Contributor

ehuss commented Sep 10, 2023

I'm not sure who to assign.

r? @compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned ehuss Sep 10, 2023
@bors
Copy link
Contributor

bors commented Sep 24, 2023

☔ The latest upstream changes (presumably #104385) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors
Copy link
Member

Sure let's do an FCP. See MCP for details.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Sep 28, 2023 •
edited by Aaron1011

Team member @compiler-errors has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 28, 2023
@compiler-errors compiler-errors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2023
@petrochenkov
Copy link
Contributor

@rfcbot concern needs-blog-post

@molecula451
Copy link

is this in part a deprecation of Windows 7 official support?

@ChrisDenton
Copy link
Contributor Author

needs-blog-post

Just to note, the intent to update Windows compatibility was announced in the Rust 1.72.0 blog post, which was a light release so there was some discussion.

@slanterns
Copy link
Contributor

slanterns commented Feb 5, 2024 •
edited

I think this PR should be merged with (and backport to) the 1.76 release this week to avoid confusion like the MIPS demotion.
(edit: since there's actually no concrete change and the target can still work on Windows 7, waiting for the next release seems also fine.)

@slanterns slanterns mentioned this pull request Feb 5, 2024
Merged
@ChrisDenton
Copy link
Contributor Author

A blog post is being prepared if anyone has any final comments. I don't know if anyone has any thoughts on post date for the blog. I'm thinking soon.

@ChrisDenton ChrisDenton mentioned this pull request Feb 26, 2024
Closed
@ChrisDenton ChrisDenton force-pushed the windows-support branch 2 times, most recently from e4b75da to b711bb2 Compare February 26, 2024 22:04
@ChrisDenton
Copy link
Contributor Author

ChrisDenton commented Feb 26, 2024 •
edited

As noted by @dpaoliello, we don't officially support XP even at tier 3 so I've also removed that. Of course no_std XP may work but it's not special in that regard. People have managed to compile Rust programs for old Windows versions at least as far back as Win95, which is great but not something that the Rust project currently supports in an official capacity.

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 10, 2024
@rfcbot
Copy link

rfcbot commented Mar 10, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rustbot
Copy link
Collaborator

rustbot commented Mar 10, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@ChrisDenton
Copy link
Contributor Author

Rebased.

@bors
Copy link
Contributor

bors commented Mar 11, 2024

☔ The latest upstream changes (presumably #122305) made this pull request unmergeable. Please resolve the merge conflicts.

@dpaoliello
Copy link
Contributor

FYI, I used the Windows targets as examples when filling out the description field in the targets, so you'll need to update the text there to: d6b597b

@ChrisDenton
Copy link
Contributor Author

I think I sneaked that in before your comment, no?

@dpaoliello
Copy link
Contributor

I think I sneaked that in before your comment, no?

Ah, you did, my bad for not checking the files...

@ChrisDenton
Copy link
Contributor Author

I probably should have made a new commit. But I am a fan of having a clean commit history 😁

@wesleywiser
Copy link
Member

The FCP has concluded, therefore:

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 11, 2024

📌 Commit 779ac69 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 11, 2024
@matthiaskrgr
Rollup merge of rust-lang#115141 - ChrisDenton:windows-support, r=wes…
7ec3516 
…leywiser

Update Windows platform support

This should not be merged until Rust 1.76 but I'm told this may need an fcp in addition to [MCP 651](rust-lang/compiler-team#651).

cc `@rust-lang/compiler` `@rust-lang/release`
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 11, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 11, 2024
@workingjubilee
Rollup merge of rust-lang#115141 - ChrisDenton:windows-support, r=wes…
805b1a8 
…leywiser

Update Windows platform support

This should not be merged until Rust 1.76 but I'm told this may need an fcp in addition to [MCP 651](rust-lang/compiler-team#651).

cc ``@rust-lang/compiler`` ``@rust-lang/release``
@workingjubilee workingjubilee mentioned this pull request Mar 11, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2024
@bors
Auto merge of rust-lang#122365 - matthiaskrgr:rollup-4i350h6, r=matth…
b0170b6 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#115141 (Update Windows platform support)
 - rust-lang#121865 (Add FileCheck annotations to MIR-opt unnamed-fields tests)
 - rust-lang#122000 (Fix 32-bit overflows in LLVM composite constants)
 - rust-lang#122194 (Enable creating backtraces via -Ztreat-err-as-bug when stashing errors)
 - rust-lang#122319 (Don't ICE when non-self part of trait goal is constrained in new solver)
 - rust-lang#122339 (Update books)
 - rust-lang#122342 (Update /NODEFAUTLIB comment for msvc)
 - rust-lang#122343 (Remove some unnecessary `allow(incomplete_features)` in the test suite)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 60ab300 into rust-lang:master Mar 12, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2024
@rust-timer
Unrolled build for rust-lang#115141
24d0dba 
Rollup merge of rust-lang#115141 - ChrisDenton:windows-support, r=wesleywiser

Update Windows platform support

This should not be merged until Rust 1.76 but I'm told this may need an fcp in addition to [MCP 651](rust-lang/compiler-team#651).

cc ```@rust-lang/compiler``` ```@rust-lang/release```
@wesleywiser wesleywiser added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 12, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@compiler-errors compiler-errors

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

None yet