Make rustc_on_unimplemented std-agnostic for alloc::rc
#115210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
approved these changes
Aug 25, 2023
|
@rustbot author |
rustbot
added
S-waiting-on-author
DogPawHat
force-pushed
the
std-agnostic-rustc_on_unimplemented-for-alloc-rc
branch
from
e1217e6
to
6ec570a
Compare
|
Squashed |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 26, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#115197 (Remove special cases that are no longer needed due to rust-lang#112606) - rust-lang#115210 (Make `rustc_on_unimplemented` std-agnostic for `alloc::rc`) - rust-lang#115237 (Fixup sparc-unknown-none-elf table spacing) - rust-lang#115244 (Migrate GUI colors test to original CSS color format) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 28, 2023
Revert "Suggest using `Arc` on `!Send`/`!Sync` types" Closes rust-lang#114687. This is a clean revert of rust-lang#88936 + rust-lang#115210. The suggestion to Arc\<{Self}\> when Self does not implement Send is *always* wrong. rust-lang#114842 is considering a way to make a more refined suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #112923
Just a few lines related to
alloc:rcforSendandSync.That seems to be all of the
... = "std::..."issues found, but there a few notes withstd::inside them still.r? @WaffleLapkin