Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it more clear what 'Tier 2' (without host tools) means #115472

Merged
merged 1 commit into from Sep 3, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 2, 2023

When saying that Rust "builds official binary releases for each tier 2 target", it's not at all clear that this does not mean we build a compiler and cargo for that target.

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2023
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 2, 2023

📌 Commit 89619b8 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
@bors
Copy link
Contributor

bors commented Sep 2, 2023

⌛ Testing commit 89619b8 with merge 278249a324e2b9a6d16b0c13cd3f581eafdaf4dd...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[01:19] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:19] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:19] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:19] / 
---
[01:18] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:18] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:18] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:18] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] / 
---
[01:16] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:16] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:16] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:16] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] / 

@bors
Copy link
Contributor

bors commented Sep 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023
@RalfJung
Copy link
Member Author

RalfJung commented Sep 2, 2023

@bors retry '/bin/sh -c /scripts/crosstool-ng-build.sh' returned a non-zero code: 1

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
@bors
Copy link
Contributor

bors commented Sep 2, 2023

⌛ Testing commit 89619b8 with merge bd5616fc5a00c992ae71c80261cf80547697f995...

@bors
Copy link
Contributor

bors commented Sep 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[00:11] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:11] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:11] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:11] / 
---
[00:22] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:22] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:22] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:22] / 
---
[01:18] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:18] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:18] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:18] / 
---
[01:19] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:19] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:19] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:19] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] / 

@RalfJung
Copy link
Member Author

RalfJung commented Sep 2, 2023

Third time in a row that I see this failure. Seems to not go away by itself, so I'll close the tree.
@bors treeclosed=100
Cc @rust-lang/infra

@RalfJung
Copy link
Member Author

RalfJung commented Sep 2, 2023

Also once the tree is open again this PR should be tried again
@bors retry '/bin/sh -c /scripts/crosstool-ng-build.sh' returned a non-zero code: 1

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
@bors
Copy link
Contributor

bors commented Sep 3, 2023

⌛ Testing commit 89619b8 with merge a989e25...

@bors
Copy link
Contributor

bors commented Sep 3, 2023

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing a989e25 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2023
@bors bors merged commit a989e25 into rust-lang:master Sep 3, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 3, 2023
@RalfJung RalfJung deleted the tier-2 branch September 3, 2023 07:38
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a989e25): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.6% [-4.7%, -2.0%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.315s -> 628.29s (-0.16%)
Artifact size: 316.70 MiB -> 316.65 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants