Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache reachable_set on disk #115740

Merged
merged 1 commit into from Sep 16, 2023
Merged

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Sep 10, 2023

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 10, 2023
@tmiasko
Copy link
Contributor Author

tmiasko commented Sep 10, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 10, 2023
@bors
Copy link
Contributor

bors commented Sep 10, 2023

⌛ Trying commit 5d3244c with merge a5a1d39f163bf802e22c4e1aa7f53ded6bc10d74...

@bors
Copy link
Contributor

bors commented Sep 10, 2023

☀️ Try build successful - checks-actions
Build commit: a5a1d39f163bf802e22c4e1aa7f53ded6bc10d74 (a5a1d39f163bf802e22c4e1aa7f53ded6bc10d74)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a5a1d39f163bf802e22c4e1aa7f53ded6bc10d74): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.4% [-2.4%, -0.4%] 5
Improvements ✅
(secondary)
-2.2% [-8.3%, -0.4%] 5
All ❌✅ (primary) -1.4% [-2.4%, -0.4%] 5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.6% [4.6%, 4.6%] 1
Improvements ✅
(primary)
-1.7% [-2.4%, -0.6%] 12
Improvements ✅
(secondary)
-4.4% [-4.9%, -4.0%] 2
All ❌✅ (primary) -1.7% [-2.4%, -0.6%] 12

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
-2.3% [-3.4%, -1.6%] 6
Improvements ✅
(secondary)
-4.0% [-8.6%, -1.9%] 5
All ❌✅ (primary) -2.3% [-3.4%, -1.6%] 6

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 629.704s -> 629.524s (-0.03%)
Artifact size: 317.61 MiB -> 317.56 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 11, 2023
@tmiasko
Copy link
Contributor Author

tmiasko commented Sep 11, 2023

r? @cjgillot

@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 16, 2023

📌 Commit 5d3244c has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023
@bors
Copy link
Contributor

bors commented Sep 16, 2023

⌛ Testing commit 5d3244c with merge fd70f7e...

@bors
Copy link
Contributor

bors commented Sep 16, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing fd70f7e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 16, 2023
@bors bors merged commit fd70f7e into rust-lang:master Sep 16, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 16, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fd70f7e): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
0.4% [0.4%, 0.6%] 4
Improvements ✅
(primary)
-1.0% [-2.4%, -0.3%] 8
Improvements ✅
(secondary)
-2.6% [-8.2%, -0.8%] 4
All ❌✅ (primary) -0.9% [-2.4%, 0.4%] 9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)
-1.6% [-2.6%, -0.9%] 16
Improvements ✅
(secondary)
-2.7% [-4.8%, -1.8%] 6
All ❌✅ (primary) -1.6% [-2.6%, -0.9%] 16

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-3.1%, -1.4%] 5
Improvements ✅
(secondary)
-4.2% [-7.9%, -3.0%] 4
All ❌✅ (primary) -2.1% [-3.1%, -1.4%] 5

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 632.342s -> 633.123s (0.12%)
Artifact size: 318.18 MiB -> 318.10 MiB (-0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Sep 16, 2023
@tmiasko tmiasko deleted the cache-reachable-set branch December 19, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants