Expand doc comment on MIR validation. #115942
Open
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
RalfJung
reviewed
Sep 18, 2023
| //! TypeChecker is meant to verify MIR types. It is used by the inliner to verify that type | ||
| //! instanciation do not mess things up (for instance #112332 and earlier instances). | ||
| //! | ||
| //! If a check depends on types, it should go in TypeChecker, otherwise it can go in CfgChecker. |
There was a problem hiding this comment.
You said it's "everything affected by substitution", not just types, right? E.g. if something depends on consts (which could be const generics) it also should go into TypeChecker?
|
think this is waiting on author to reply this comment @rustbot author |
rustbot
added
S-waiting-on-author
apiraino
reviewed
Oct 19, 2023
| //! statements and terminators... | ||
| //! | ||
| //! TypeChecker is meant to verify MIR types. It is used by the inliner to verify that type | ||
| //! instanciation do not mess things up (for instance #112332 and earlier instances). |
There was a problem hiding this comment.
Suggested change
| //! instanciation do not mess things up (for instance #112332 and earlier instances). | |
| //! instantiation do not mess things up (for instance #112332 and earlier instances). |
typo?
|
@cjgillot I think this just needs some minor wording changes? |
|
@cjgillot I recently noticed that both validators check retags. Is that kind of duplication of the checking logic expected behavior? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung