Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostics: avoid mismatch between variance index and hir generic #116045

Merged
merged 2 commits into from
Sep 23, 2023
Merged

diagnostics: avoid mismatch between variance index and hir generic #116045

merged 2 commits into from
Sep 23, 2023

Commits on Sep 22, 2023

  1. diagnostics: avoid mismatch between variance index and hir generic 

    This happens because variances are constructed from ty generics,
and ty generics are always constructed with lifetimes first.

See compiler/rustc_hir_analysis/src/collect/generics_of.rs:248-269

Fixes rust-lang#83556
    @notriddle
    notriddle committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    3799af3 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. diagnostics: simpler 83556 handling by bailing out

    @notriddle
    notriddle committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    58ef3a0 View commit details
    Browse the repository at this point in the history