Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the FileEncoder file for reading and writing #116067

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

saethlin
Copy link
Member

Maybe I just don't know File well enough, but the previous comment didn't make it clear enough to me that we can't use File::create. This one does.

Fixes #116055

r? @WaffleLapkin

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 22, 2023
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, yeah, I missed this too 💀

r=me with tidy being dealt with

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 22, 2023
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

tests/ui/meta-stats.rs Outdated Show resolved Hide resolved
@saethlin saethlin force-pushed the meta-stats-ice branch 2 times, most recently from 18029df to f7f7d5e Compare September 22, 2023 20:01
@rust-log-analyzer

This comment has been minimized.

@saethlin
Copy link
Member Author

@bors r=WaffleLapkin

@bors
Copy link
Contributor

bors commented Sep 22, 2023

📌 Commit 09960e0 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#115770 (Match on elem first while building move paths)
 - rust-lang#115999 (Capture scrutinee of if let guards correctly)
 - rust-lang#116056 (Make unsized casts illegal)
 - rust-lang#116061 (Remove TaKO8Ki from review rotation)
 - rust-lang#116062 (Change `start` to `#[start]` in some diagnosis)
 - rust-lang#116067 (Open the FileEncoder file for reading and writing)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit efee13a into rust-lang:master Sep 22, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023
Rollup merge of rust-lang#116067 - saethlin:meta-stats-ice, r=WaffleLapkin

Open the FileEncoder file for reading and writing

Maybe I just don't know `File` well enough, but the previous comment didn't make it clear enough to me that we can't use `File::create`. This one does.

Fixes rust-lang#116055

r? `@WaffleLapkin`
@rustbot rustbot added this to the 1.74.0 milestone Sep 22, 2023
@saethlin saethlin deleted the meta-stats-ice branch November 9, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ice: -Zmeta-stats Bad file descriptor
6 participants