Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overflow in IoSlice::advance_slices #116070

Merged
merged 1 commit into from Sep 25, 2023

Conversation

eduardosm
Copy link
Contributor

Noticed in #62726 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 22, 2023
@eduardosm eduardosm force-pushed the IoSlice-advance_slices-checked_add branch 2 times, most recently from 6af9549 to c225878 Compare September 22, 2023 18:45
@eduardosm eduardosm force-pushed the IoSlice-advance_slices-checked_add branch from c225878 to 9386338 Compare September 23, 2023 14:28
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2023

📌 Commit 9386338 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2023
@bors
Copy link
Contributor

bors commented Sep 25, 2023

⌛ Testing commit 9386338 with merge 6971227...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2023
…cked_add, r=Mark-Simulacrum

Avoid overflow in `IoSlice::advance_slices`

Noticed in rust-lang#62726 (comment).
@bors
Copy link
Contributor

bors commented Sep 25, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 25, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@compiler-errors
Copy link
Member

@bors retry spurious

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2023
@bors
Copy link
Contributor

bors commented Sep 25, 2023

⌛ Testing commit 9386338 with merge 8e30726...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2023
…cked_add, r=Mark-Simulacrum

Avoid overflow in `IoSlice::advance_slices`

Noticed in rust-lang#62726 (comment).
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
 "NO_DEBUG_ASSERTIONS": 1,
 "NO_OVERFLOW_CHECKS": 1
}
##[endgroup]
jq: error: Top-level program not given (try ".")
jq: 1 compile error
##[error]Process completed with exit code 3.
[command]/usr/local/bin/git version
git version 2.42.0
Copying '/Users/runner/.gitconfig' to '/Users/runner/work/_temp/6874a12a-f302-47c7-b413-2c480d9e224a/.gitconfig'
Temporarily overriding HOME='/Users/runner/work/_temp/6874a12a-f302-47c7-b413-2c480d9e224a' before making global git config changes

@bors
Copy link
Contributor

bors commented Sep 25, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 25, 2023
@compiler-errors
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2023
@bors
Copy link
Contributor

bors commented Sep 25, 2023

⌛ Testing commit 9386338 with merge 7bf47a4...

@bors
Copy link
Contributor

bors commented Sep 25, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7bf47a4 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Sep 25, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7bf47a4 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Sep 25, 2023
@bors bors merged commit 7bf47a4 into rust-lang:master Sep 25, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 25, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7bf47a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
5.5% [1.3%, 9.7%] 5
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.2% [-2.5%, 9.7%] 6

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.0%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.1%, -0.0%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.0% [-0.1%, 0.0%] 5

Bootstrap: 631.251s -> 630.824s (-0.07%)
Artifact size: 317.22 MiB -> 317.29 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants