Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that closure/generator's interior/capture types are sized #116081

Merged
merged 2 commits into from Sep 23, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Sep 23, 2023

check that closure upvars and generator interiors are sized. this check is only necessary when unsized_fn_params or unsized_locals is enabled, so only check if those are active.

Fixes #93622
Fixes #61335
Fixes #68543

@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 23, 2023
@compiler-errors compiler-errors changed the title Check that closure's by-value captures are sized Check that closure/generator's interior/capture types are sized Sep 23, 2023
@cjgillot
Copy link
Contributor

Great!
@bors r+

@bors
Copy link
Contributor

bors commented Sep 23, 2023

📌 Commit 79d6853 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2023
@bors
Copy link
Contributor

bors commented Sep 23, 2023

⌛ Testing commit 79d6853 with merge 3050938...

@bors
Copy link
Contributor

bors commented Sep 23, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 3050938 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 23, 2023
@bors bors merged commit 3050938 into rust-lang:master Sep 23, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 23, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3050938): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.28s -> 634.954s (0.11%)
Artifact size: 317.90 MiB -> 317.84 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
5 participants