Don't use a thread to load the dep graph #116109

Zoxc · 2023-09-23T22:34:48Z

This removes the use of a thread to load the dep graph. It's not currently useful as we immediately block on it.

oli-obk · 2023-09-25T17:47:36Z

bors · 2023-09-25T17:48:45Z

⌛ Trying commit ba8d53d with merge b2bb63f...

Don't use a thread to load the dep graph This removes the use of a thread to load the dep graph. It's not currently useful as we immediately block on it. r? `@oli-obk`

bors · 2023-09-25T18:58:48Z

☀️ Try build successful - checks-actions
Build commit: b2bb63f (b2bb63fbb35a74e9c9f5741ac905ae2b69fceef9)

rust-timer · 2023-09-26T04:49:11Z

Finished benchmarking commit (b2bb63f): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	3.4%	[2.0%, 6.7%]	5
Improvements ✅ (primary)	-2.7%	[-4.9%, -0.4%]	5
Improvements ✅ (secondary)	-2.1%	[-3.0%, -1.7%]	3
All ❌✅ (primary)	-2.1%	[-4.9%, 1.2%]	6

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.116s -> 631.38s (-0.12%)
Artifact size: 317.31 MiB -> 317.26 MiB (-0.02%)

oli-obk · 2023-09-26T07:47:48Z

@bors r+

bors · 2023-09-26T07:47:50Z

📌 Commit ba8d53d has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-09-26T10:34:59Z

⌛ Testing commit ba8d53d with merge 8bf0dec...

bors · 2023-09-26T12:31:15Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 8bf0dec to master...

rust-timer · 2023-09-26T14:15:24Z

Finished benchmarking commit (8bf0dec): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.5%, 1.1%]	2
Regressions ❌ (secondary)	0.5%	[0.1%, 1.2%]	3
Improvements ✅ (primary)	-0.2%	[-0.3%, -0.2%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.3%, 1.1%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.4%, 2.8%]	3
Regressions ❌ (secondary)	3.4%	[2.2%, 6.5%]	5
Improvements ✅ (primary)	-2.5%	[-3.8%, -1.2%]	3
Improvements ✅ (secondary)	-2.4%	[-3.0%, -1.7%]	4
All ❌✅ (primary)	-0.6%	[-3.8%, 2.8%]	6

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.717s -> 631.784s (0.01%)
Artifact size: 317.30 MiB -> 317.18 MiB (-0.04%)

Zoxc · 2023-09-26T19:38:37Z

compiler/rustc_incremental/src/persist/load.rs

+    let res = sess.opts.build_dep_graph().then(|| load_dep_graph(sess));
+
+    if sess.opts.incremental.is_some() {
+        sess.time("incr_comp_garbage_collect_session_directories", || {


There does seem to be a small performance hit which is probably this no longer being done in parallel.

looks like noise to me on the graph of the regressed perf tests

It does look like the time incr_comp_garbage_collect_session_directories takes in practice is quite small, so it's probably just noise.

Probably a relative/absolute graph thingy again. It looks small and maybe not worth looking into, but seems unlikely to be noise with this shape.

I was referring to the wall time regression in the initial perf run. The instruction count isn't very useful as this PR involves parallelism.

rylev · 2023-10-03T13:53:48Z

@Zoxc @oli-obk did we come to a conclusion on whether this small perf regression needs to be addressed? I guess given the nature of the PR (doing with parallelism), the instruction count regression is fine to just accept, right?

@rustbot label: +perf-regression-triaged

Don't use a thread to load the dep graph

ba8d53d

rustbot assigned oli-obk Sep 23, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 23, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 25, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 26, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 26, 2023

bors merged commit 8bf0dec into rust-lang:master Sep 26, 2023
12 checks passed

rustbot added this to the 1.74.0 milestone Sep 26, 2023

rustbot added the perf-regression Performance regression. label Sep 26, 2023

Zoxc deleted the no-dep-graph-thread branch September 26, 2023 19:34

Zoxc commented Sep 26, 2023

View reviewed changes

rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't use a thread to load the dep graph #116109

Don't use a thread to load the dep graph #116109

Zoxc commented Sep 23, 2023

oli-obk commented Sep 25, 2023

This comment has been minimized.

bors commented Sep 25, 2023

bors commented Sep 25, 2023

This comment has been minimized.

rust-timer commented Sep 26, 2023

oli-obk commented Sep 26, 2023

bors commented Sep 26, 2023

bors commented Sep 26, 2023

bors commented Sep 26, 2023

rust-timer commented Sep 26, 2023

Zoxc Sep 26, 2023

oli-obk Sep 27, 2023

Zoxc Sep 27, 2023

lqd Sep 27, 2023 •

edited

Zoxc Sep 27, 2023

rylev commented Oct 3, 2023

Don't use a thread to load the dep graph #116109

Don't use a thread to load the dep graph #116109

Conversation

Zoxc commented Sep 23, 2023

oli-obk commented Sep 25, 2023

This comment has been minimized.

bors commented Sep 25, 2023

bors commented Sep 25, 2023

This comment has been minimized.

rust-timer commented Sep 26, 2023

Overall result: ❌ regressions - no action needed

oli-obk commented Sep 26, 2023

bors commented Sep 26, 2023

bors commented Sep 26, 2023

bors commented Sep 26, 2023

rust-timer commented Sep 26, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lqd Sep 27, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rylev commented Oct 3, 2023

lqd Sep 27, 2023 •

edited